Bug 167813

Summary: Guard and unguard ports in a much less intrusive way
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, rniwa
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews104 for mac-elcapitan-wk2
none
Patch sam: review+

Anders Carlsson
Reported 2017-02-03 14:05:30 PST
Guard and unguard ports in a much less intrusive way
Attachments
Patch (2.49 KB, patch)
2017-02-03 14:06 PST, Anders Carlsson 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews104 for mac-elcapitan-wk2 (1.06 MB, application/zip)
2017-02-03 14:52 PST, Build Bot 		no flags
Details
Patch (2.86 KB, patch)
2017-02-03 15:16 PST, Anders Carlsson 		sam: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2017-02-03 14:06:21 PST
Created attachment 300562 [details] Patch
Build Bot
Comment 2 2017-02-03 14:52:16 PST
Comment on attachment 300562 [details] Patch Attachment 300562 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/3000233 New failing tests: http/tests/xmlhttprequest/resetting-timeout-to-zero.html
Build Bot
Comment 3 2017-02-03 14:52:20 PST
Created attachment 300565 [details] Archive of layout-test-results from ews104 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6
Anders Carlsson
Comment 4 2017-02-03 15:16:26 PST
Created attachment 300569 [details] Patch
Sam Weinig
Comment 5 2017-02-03 17:38:21 PST
Comment on attachment 300569 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=300569&action=review > Source/WebKit2/ChangeLog:8 > + Instead of adopting mach_port_construct/mach_port_destruct, just guard and unguard the ports where appropriate. I am a bit confused about the "instead" here. Is there a bug where you adopted mach_port_construct/mach_port_destruct?
Anders Carlsson
Comment 6 2017-02-06 08:53:07 PST
(In reply to comment #5) > Comment on attachment 300569 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=300569&action=review > > > Source/WebKit2/ChangeLog:8 > > + Instead of adopting mach_port_construct/mach_port_destruct, just guard and unguard the ports where appropriate. > > I am a bit confused about the "instead" here. Is there a bug where you > adopted mach_port_construct/mach_port_destruct? Yes.
Anders Carlsson
Comment 7 2017-02-06 08:56:03 PST
Committed r211726: <http://trac.webkit.org/changeset/211726>
Note You need to log in before you can comment on or make changes to this bug.