Bug 167806

Summary: JSDOMConvert is too big. Split it up!
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal CC: ap
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Sam Weinig
Reported 2017-02-03 12:08:13 PST
JSDOMConvert is too big. Split it up!
Attachments
Patch (3.53 MB, patch)
2017-02-03 12:28 PST, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (3.53 MB, patch)
2017-02-03 17:34 PST, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2017-02-03 12:28:17 PST
Created attachment 300558 [details] Patch
Geoffrey Garen
Comment 2 2017-02-03 13:53:38 PST
Comment on attachment 300558 [details] Patch > + Split JSDOMConvert up roughly by IDL type. Some are grouped for connivence, e.g. all the convenience rs=me once it applies cleanly
Sam Weinig
Comment 3 2017-02-03 17:34:32 PST
Created attachment 300583 [details] Patch
Sam Weinig
Comment 4 2017-02-03 17:44:03 PST
The patch was created using webkit-patch post, with no conflicts in the local tree and svn up to date. I think it's probably a bug in either svn-create-patch or svn-apply :(.
Alexey Proskuryakov
Comment 5 2017-02-05 17:25:33 PST
Sam, could you please file a bug?
Sam Weinig
Comment 6 2017-02-06 13:26:34 PST
(In reply to comment #5) > Sam, could you please file a bug? https://bugs.webkit.org/show_bug.cgi?id=167903
Sam Weinig
Comment 7 2017-02-06 13:27:02 PST
(In reply to comment #5) > Sam, could you please file a bug? Any ideas about what I can do to make it work in the mean time. It's a big enough change I don't want to land without some testing.
Alexey Proskuryakov
Comment 8 2017-02-06 16:06:47 PST
Hmm, maybe try rolling tools directory back a couple weeks? This has to be a recent regression.
Sam Weinig
Comment 9 2017-02-07 10:56:54 PST
Committed r211821: <http://trac.webkit.org/changeset/211821>
Note You need to log in before you can comment on or make changes to this bug.