Bug 167793

Summary: [Modern Media Controls] Skip back button is visible with a live broadcast video
Product: WebKit Reporter: Antoine Quint <graouts>
Component: MediaAssignee: Antoine Quint <graouts>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Safari Technology Preview   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Testcase
none
Patch none

Antoine Quint
Reported 2017-02-03 08:27:50 PST
Created attachment 300533 [details] Testcase We shouldn't be showing the skip back button for a live broadcast video.
Attachments
Testcase (257 bytes, text/html)
2017-02-03 08:27 PST, Antoine Quint 		no flags
Details
Patch (5.30 KB, patch)
2017-02-03 09:26 PST, Antoine Quint 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2017-02-03 08:28:12 PST
<rdar://problem/30348780>
Antoine Quint
Comment 2 2017-02-03 09:06:18 PST
We simply need to teach SkipBackSupport about the "durationchange" event and check when we have an infinity duration video (ie. live broadcast) to toggle the control's enabled state.
Antoine Quint
Comment 3 2017-02-03 09:26:48 PST
Created attachment 300538 [details] Patch
WebKit Commit Bot
Comment 4 2017-02-03 11:55:04 PST
Comment on attachment 300538 [details] Patch Clearing flags on attachment: 300538 Committed r211641: <http://trac.webkit.org/changeset/211641>
WebKit Commit Bot
Comment 5 2017-02-03 11:55:07 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.