Summary: | Language specific bindings cannot cache/reuse previously created Instances and RuntimeObjects | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Michael Goddard <michael.goddard> | ||||||
Component: | JavaScriptCore | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | andersca | ||||||
Priority: | P3 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | PC | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Michael Goddard
2008-01-07 16:13:00 PST
Created attachment 18320 [details]
Proposed patch (adds caching for Qt bindings)
Hmm.. patch (id 18320) not quite complete - doesn't handle the case when an Instance has a ref from someone apart from the RuntimeObjectImp (so the RuntimeObjectImp can be deleted without the cache noticing, and reuses an old pointer). New patch soon. Created attachment 18337 [details]
Updated patch - better Qt RuntimeObjectImp lifetime management
Comment on attachment 18337 [details] Updated patch - better Qt RuntimeObjectImp lifetime management >+ virtual BindingLanguage getBindingLanguage() const {return CLanguage;} Need spaces after the open brace and before the close brace. >+ virtual BindingLanguage getBindingLanguage() const {return JavaLanguage;} Here too. >+ virtual BindingLanguage getBindingLanguage() const {return ObjectiveCLanguage;} Here too. >+ virtual BindingLanguage getBindingLanguage() const {return QtLanguage;} And here :) This looks great otherwise, r=me. |