Bug 167705

Summary: Simple line layout: Move TextFragmentIterator::runWidth to ::textWidth.
Product: WebKit Reporter: alan <zalan>
Component: Layout and RenderingAssignee: alan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, esprehn+autocc, glenn, koivisto, kondapallykalyan, mmaxfield, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

alan
Reported 2017-02-01 13:11:24 PST
No one else calls runWidth.
Attachments
Patch (7.07 KB, patch)
2017-02-01 13:15 PST, alan 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2017-02-01 13:12:55 PST
<rdar://problem/30314393>
alan
Comment 2 2017-02-01 13:15:09 PST
Created attachment 300347 [details] Patch
Antti Koivisto
Comment 3 2017-02-01 13:18:06 PST
Comment on attachment 300347 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=300347&action=review > Source/WebCore/rendering/SimpleLineLayout.cpp:607 > + line.setLogicalLeftOffset(flow.logicalLeftOffsetForLine(height, DoNotIndentText) + (shouldApplyTextIndent && isFirstLine ? flow.textIndentOffset() : LayoutUnit(0))); Wonder if that LayoutUnit(0) could be just { 0 }
WebKit Commit Bot
Comment 4 2017-02-01 14:27:24 PST
Comment on attachment 300347 [details] Patch Clearing flags on attachment: 300347 Committed r211531: <http://trac.webkit.org/changeset/211531>
WebKit Commit Bot
Comment 5 2017-02-01 14:27:28 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.