Bug 167678

Summary:

Multiple HTTP tests fail with Apache 2.4.25

Product:

WebKit

Reporter:

Alexey Proskuryakov <ap>

Component:

Tools / Tests

Assignee:

Alexey Proskuryakov <ap>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, commit-queue, dbates, koivisto, lforschler, mkwst, ryanhaddad

Priority:

Keywords:

InRadar

Version:

Safari 9

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
proposed fix	none

Alexey Proskuryakov

Reported 2017-01-31 17:56:22 PST

Apache 2.4.25 includes a fix to validate incoming and outgoing header field names, which breaks our tests that verify the behavior with broken ones. The affected tests are: http/tests/cache/disk-cache/disk-cache-validation-attachment.html http/tests/misc/non-utf8-header-name.php http/tests/preload/download_resources_from_invalid_headers.html http/tests/security/contentSecurityPolicy/directive-parsing-03.html http/tests/security/contentSecurityPolicy/source-list-parsing-04.html

Attachments
proposed fix (34.62 KB, patch) 2017-02-02 10:15 PST, Alexey Proskuryakov	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Alexey Proskuryakov

Comment 1 2017-01-31 18:02:16 PST

There is an option to disable the checks (HttpProtocolOptions Unsafe), but looks like it only fixes one of these tests.

Alexey Proskuryakov

Comment 2 2017-02-01 09:15:38 PST

<rdar://problem/30060142>

Alexey Proskuryakov

Comment 3 2017-02-02 10:15:16 PST

Created attachment 300418 [details] proposed fix

WebKit Commit Bot

Comment 4 2017-02-02 17:47:52 PST

Comment on attachment 300418 [details] proposed fix Clearing flags on attachment: 300418 Committed r211616: <http://trac.webkit.org/changeset/211616>

WebKit Commit Bot

Comment 5 2017-02-02 17:47:57 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.