Bug 167677

Summary: AX: Incorrect range from index and length in text controls when there are newlines
Product: WebKit Reporter: Nan Wang <n_wang>
Component: AccessibilityAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, apinheiro, cfleizach, commit-queue, dmazzoni, jcraig, jdiggs, mario, n_wang, samuel_white, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
patch
none
patch
none
patch
cfleizach: review+
patch none

Nan Wang
Reported 2017-01-31 17:52:38 PST
doAXStringForRange(const PlainTextRange&) and doAXBoundsForRange(const PlainTextRange&) sometimes return wrong information when the text control contains newlines. <rdar://problem/30187854>
Attachments
patch (6.36 KB, patch)
2017-01-31 18:03 PST, Nan Wang 		no flags
DetailsFormatted DiffDiff
patch (6.74 KB, patch)
2017-01-31 18:14 PST, Nan Wang 		no flags
DetailsFormatted DiffDiff
patch (6.79 KB, patch)
2017-01-31 18:22 PST, Nan Wang 		cfleizach: review+
DetailsFormatted DiffDiff
patch (8.35 KB, patch)
2017-02-01 09:50 PST, Nan Wang 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2017-01-31 17:52:49 PST
<rdar://problem/30300099>
Nan Wang
Comment 2 2017-01-31 18:03:30 PST
Created attachment 300290 [details] patch
chris fleizach
Comment 3 2017-01-31 18:07:44 PST
Comment on attachment 300290 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=300290&action=review > LayoutTests/accessibility/mac/range-for-contenteditable-newline.html:9 > +<div id="textcontrol" contenteditable="true">some<div>hello world</div><div>test</div></div> can you also add an input type=text test case too
Nan Wang
Comment 4 2017-01-31 18:14:34 PST
Created attachment 300291 [details] patch added test case
chris fleizach
Comment 5 2017-01-31 18:16:47 PST
Comment on attachment 300291 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=300291&action=review > LayoutTests/accessibility/mac/range-for-contenteditable-newline.html:10 > +<input type="text" id="input" value="hello world"> I guess input type=text doesn't have newlines. we should also check <textarea> sorry
Nan Wang
Comment 6 2017-01-31 18:22:34 PST
Created attachment 300292 [details] patch sure, test <textarea> instead
Nan Wang
Comment 7 2017-02-01 09:50:22 PST
Created attachment 300333 [details] patch Found an issue where a wrong position is retrieved if there are multiple <br> in the text control.
WebKit Commit Bot
Comment 8 2017-02-01 10:13:33 PST
Comment on attachment 300333 [details] patch Clearing flags on attachment: 300333 Committed r211491: <http://trac.webkit.org/changeset/211491>
WebKit Commit Bot
Comment 9 2017-02-01 10:13:38 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.