Bug 167660

Summary:

Load resources speculatively

Product:

WebKit

Reporter:

Antti Koivisto <koivisto>

Component:

Page Loading

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

beidson, benjamin, buildbot, cdumez, cgarcia, cmarcelo, commit-queue, dbates, rniwa, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
patch	none
patch	kling: review+, buildbot: commit-queue-
Archive of layout-test-results from ews105 for mac-elcapitan-wk2	none
Archive of layout-test-results from ews121 for ios-simulator-wk2	none
patch	none
patch	none

Antti Koivisto

Reported 2017-01-31 13:28:24 PST

We currently validate expired cache resources speculatively based on historical data. Expand this to also trigger normal loads speculatively.

Attachments
patch (25.81 KB, patch) 2017-01-31 14:04 PST, Antti Koivisto	no flags	Details Formatted Diff Diff
patch (24.61 KB, patch) 2017-02-01 01:45 PST, Antti Koivisto	kling: review+ buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews105 for mac-elcapitan-wk2 (828.71 KB, application/zip) 2017-02-01 02:49 PST, Build Bot	no flags	Details
Archive of layout-test-results from ews121 for ios-simulator-wk2 (866.09 KB, application/zip) 2017-02-01 03:01 PST, Build Bot	no flags	Details
patch (25.15 KB, patch) 2017-02-01 04:35 PST, Antti Koivisto	no flags	Details Formatted Diff Diff
patch (24.64 KB, patch) 2017-02-01 04:45 PST, Antti Koivisto	no flags	Details Formatted Diff Diff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.

Antti Koivisto

Comment 1 2017-01-31 14:04:16 PST

Created attachment 300257 [details] patch

Antti Koivisto

Comment 2 2017-02-01 01:45:12 PST

Created attachment 300306 [details] patch

Andreas Kling

Comment 3 2017-02-01 02:22:15 PST

Comment on attachment 300306 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=300306&action=review r=me > Source/WebKit2/NetworkProcess/cache/NetworkCacheSpeculativeLoadManager.cpp:516 > + if (ageRatio > minimumAgeRatio) > + return true; Should probably be >=

Build Bot

Comment 4 2017-02-01 02:49:02 PST

Comment on attachment 300306 [details] patch Attachment 300306 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/2984584 New failing tests: http/tests/cache/disk-cache/speculative-validation/http-auth.html

Build Bot

Comment 5 2017-02-01 02:49:09 PST

Created attachment 300310 [details] Archive of layout-test-results from ews105 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6

Build Bot

Comment 6 2017-02-01 03:01:00 PST

Comment on attachment 300306 [details] patch Attachment 300306 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/2984634 New failing tests: http/tests/cache/disk-cache/speculative-validation/http-auth.html

Build Bot

Comment 7 2017-02-01 03:01:05 PST

Created attachment 300312 [details] Archive of layout-test-results from ews121 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews121 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.6

Antti Koivisto

Comment 8 2017-02-01 04:35:01 PST

Created attachment 300320 [details] patch

Antti Koivisto

Comment 9 2017-02-01 04:45:32 PST

Created attachment 300321 [details] patch

Antti Koivisto

Comment 10 2017-02-01 05:40:17 PST

Committed r211480: <http://trac.webkit.org/changeset/211480>

Radar WebKit Bug Importer

Comment 11 2017-02-01 05:41:16 PST

<rdar://problem/30306159>

Note You need to log in before you can comment on or make changes to this bug.