Bug 167660

Summary:

Load resources speculatively

Product:

WebKit

Reporter:

Antti Koivisto <koivisto>

Component:

Page Loading

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

beidson, benjamin, buildbot, cdumez, cgarcia, cmarcelo, commit-queue, dbates, rniwa, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
patch	none
patch	kling: review+, buildbot: commit-queue-
Archive of layout-test-results from ews105 for mac-elcapitan-wk2	none
Archive of layout-test-results from ews121 for ios-simulator-wk2	none
patch	none
patch	none

Description Antti Koivisto 2017-01-31 13:28:24 PST

We currently validate expired cache resources speculatively based on historical data. Expand this to also trigger normal loads speculatively.

Comment 1 Antti Koivisto 2017-01-31 14:04:16 PST

Created attachment 300257 [details]
patch

Comment 2 Antti Koivisto 2017-02-01 01:45:12 PST

Created attachment 300306 [details]
patch

Comment 3 Andreas Kling 2017-02-01 02:22:15 PST

Comment on attachment 300306 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=300306&action=review

r=me

> Source/WebKit2/NetworkProcess/cache/NetworkCacheSpeculativeLoadManager.cpp:516
> +    if (ageRatio > minimumAgeRatio)
> +        return true;

Should probably be >=

Comment 4 Build Bot 2017-02-01 02:49:02 PST

Comment on attachment 300306 [details]
patch

Attachment 300306 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2984584

New failing tests:
http/tests/cache/disk-cache/speculative-validation/http-auth.html

Comment 5 Build Bot 2017-02-01 02:49:09 PST

Created attachment 300310 [details]
Archive of layout-test-results from ews105 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

Comment 6 Build Bot 2017-02-01 03:01:00 PST

Comment on attachment 300306 [details]
patch

Attachment 300306 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2984634

New failing tests:
http/tests/cache/disk-cache/speculative-validation/http-auth.html

Comment 7 Build Bot 2017-02-01 03:01:05 PST

Created attachment 300312 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6

Comment 8 Antti Koivisto 2017-02-01 04:35:01 PST

Created attachment 300320 [details]
patch

Comment 9 Antti Koivisto 2017-02-01 04:45:32 PST

Created attachment 300321 [details]
patch

Comment 10 Antti Koivisto 2017-02-01 05:40:17 PST

Committed r211480: <http://trac.webkit.org/changeset/211480>

Comment 11 Radar WebKit Bug Importer 2017-02-01 05:41:16 PST

<rdar://problem/30306159>