Summary: | imported/w3c/web-platform-tests/shadow-dom/slotchange.html is a flaky failure | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ryan Haddad <ryanhaddad> | ||||||
Component: | New Bugs | Assignee: | Ryosuke Niwa <rniwa> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | cdumez, dbates, esprehn+autocc, ews-watchlist, ggaren, jlewis3, kangil.han, keith_miller, lforschler, msaboff, rniwa, saam, simon.fraser, webkit-bug-importer, youennf | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | 177597 | ||||||||
Bug Blocks: | 148695 | ||||||||
Attachments: |
|
Description
Ryan Haddad
2017-01-31 10:57:24 PST
Marked test as flaky in http://trac.webkit.org/projects/webkit/changeset/211593 This has since started to be a flaky timeout on Sierra as well: https://build.webkit.org/results/Apple%20Sierra%20Debug%20WK2%20(Tests)/r222625%20(3254)/results.html https://build.webkit.org/builders/Apple%20Sierra%20Debug%20WK2%20(Tests)/builds/3254 Created attachment 350479 [details] Reduction The issue here is that the JS wrapper of a HTMLSlotElement can be prematurely collected. We need to use the GC retention mechanism we introduced in https://bugs.webkit.org/show_bug.cgi?id=184307 to keep these slot elements alive. Created attachment 350486 [details]
Fixes the bug
Comment on attachment 350486 [details] Fixes the bug View in context: https://bugs.webkit.org/attachment.cgi?id=350486&action=review > LayoutTests/fast/shadow-dom/signal-slot-list-retains-js-wrappers.html:27 > + const x = new Array(100); This path is used for in-browser testing. This test also catches the same bug in Chrome sometimes LOL Attachment 350486 [details] did not pass style-queue:
ERROR: Source/WebCore/dom/MutationObserver.cpp:193: More than one command on the same line [whitespace/newline] [4]
Total errors found: 1 in 5 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 350486 [details]
Fixes the bug
r=me seems reasonable
Comment on attachment 350486 [details] Fixes the bug Clearing flags on attachment: 350486 Committed r236440: <https://trac.webkit.org/changeset/236440> All reviewed patches have been landed. Closing bug. Removed the failing test expectation in https://trac.webkit.org/r236710 now that I observe the test isn't failing on the flakiness dashboard. |