| Summary: | Compilation error in JSArrayBufferView.h | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Tomas Popela <tpopela> | ||||
| Component: | JavaScriptCore | Assignee: | Tomas Popela <tpopela> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | commit-queue, fpizlo, keith_miller, mark.lam, mcatanzaro, msaboff, saam | ||||
| Priority: | P2 | ||||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
Created attachment 300218 [details]
Patch
No clue whether this is a WebKit bug or a GCC 7 bug. Comment on attachment 300218 [details]
Patch
const should definitely be there
Comment on attachment 300218 [details] Patch Clearing flags on attachment: 300218 Committed r211434: <http://trac.webkit.org/changeset/211434> All reviewed patches have been landed. Closing bug. |
In file included from /builddir/build/BUILD/webkitgtk-2.15.4/Source/JavaScriptCore/runtime/JSGenericTypedArrayViewInlines.h:33:0, from /builddir/build/BUILD/webkitgtk-2.15.4/Source/JavaScriptCore/API/JSTypedArray.cpp:37: /builddir/build/BUILD/webkitgtk-2.15.4/Source/JavaScriptCore/runtime/JSGenericTypedArrayView.h: In member function 'const typename Adaptor::Type* JSC::JSGenericTypedArrayView<Adaptor>::typedVector() const': /builddir/build/BUILD/webkitgtk-2.15.4/Source/JavaScriptCore/runtime/JSGenericTypedArrayView.h:119:67: error: no matching function for call to 'JSC::JSGenericTypedArrayView<Adaptor>::vector() const' return bitwise_cast<const typename Adaptor::Type*>(vector()); ^ In file included from /builddir/build/BUILD/webkitgtk-2.15.4/Source/JavaScriptCore/runtime/JSArrayBufferViewInlines.h:29:0, from /builddir/build/BUILD/webkitgtk-2.15.4/Source/JavaScriptCore/API/JSTypedArray.cpp:34: /builddir/build/BUILD/webkitgtk-2.15.4/Source/JavaScriptCore/runtime/JSArrayBufferView.h:170:11: note: candidate: void* JSC::JSArrayBufferView::vector() <nearmatch> void* vector() { return m_vector.get(); } ^~~~~~ /builddir/build/BUILD/webkitgtk-2.15.4/Source/JavaScriptCore/runtime/JSArrayBufferView.h:170:11: note: passing 'const JSC::JSGenericTypedArrayView<Adaptor>*' as 'this' argument discards qualifiers