Bug 167636 – [EME] Implement MediaKeySession::update()

• Component: New Bugs
• Status: RESOLVED FIXED

[Zan Dobersek]

[EME] Implement MediaKeySession::update()

[Zan Dobersek]

Created attachment 300200 [details]
Patch

[WebKit Commit Bot]

Attachment 300200 [details] did not pass style-queue:


ERROR: Source/WebCore/testing/MockCDMFactory.cpp:186:  Missing space before {  [whitespace/braces] [5]
ERROR: Source/WebCore/testing/MockCDMFactory.cpp:282:  Missing space before {  [whitespace/braces] [5]
Total errors found: 2 in 12 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Xabier Rodríguez Calvar]

Comment on attachment 300200 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=300200&action=review

Other than a couple of nits, I think it is ok. Jer, Eric, how does this look to you?

> Source/WebCore/Modules/encryptedmedia/MediaKeySession.cpp:354
> +                    // TODO: At this point the implementations of preceding steps can't fail.

FIXME.

> Source/WebCore/testing/MockCDMFactory.cpp:186
> +    String{ response.data(), response.size() }.split(ASCIILiteral(" "), responseArray);

String {

> Source/WebCore/testing/MockCDMFactory.cpp:282
> +    String{ response.data(), response.size() }.split(ASCIILiteral(" "), responseVector);

String {

> Source/WebCore/testing/MockCDMFactory.cpp:289
> +    // TODO: Session closure, key status, expiration and message handling should be implemented

FIXME

> LayoutTests/media/encrypted-media/mock-MediaKeySession-update.html:93
> +                    run('promise = mediaKeySession.update(stringToUInt8Array("invalid-response"))');
> +                    shouldReject(promise).then(next, next);
> +                }, next);

These lines seem to be not properly indented.

> LayoutTests/media/encrypted-media/mock-MediaKeySession-update.html:104
> +                    run('promise = mediaKeySession.update(stringToUInt8Array("valid-response"))');
> +                    shouldResolve(promise).then(next, next);
> +                }, next);

Ditto.

> LayoutTests/media/encrypted-media/mock-MediaKeySession-update.html:115
> +                    run('promise = mediaKeySession.update(stringToUInt8Array("valid-response invalid-format"))');
> +                    shouldReject(promise).then(next, next);
> +                }, next);

Ditto.

[Build Bot]

Comment on attachment 300200 [details]
Patch

Attachment 300200 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2978929

New failing tests:
media/encrypted-media/mock-MediaKeySession-update.html

[Build Bot]

Created attachment 300202 [details]
Archive of layout-test-results from ews102 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 300200 [details]
Patch

Attachment 300200 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2978935

New failing tests:
media/encrypted-media/mock-MediaKeySession-update.html

[Build Bot]

Created attachment 300203 [details]
Archive of layout-test-results from ews107 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 300200 [details]
Patch

Attachment 300200 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2978951

New failing tests:
media/encrypted-media/mock-MediaKeySession-update.html

[Build Bot]

Created attachment 300204 [details]
Archive of layout-test-results from ews114 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Zan Dobersek]

Comment on attachment 300200 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=300200&action=review

>> Source/WebCore/testing/MockCDMFactory.cpp:282
>> +    String{ response.data(), response.size() }.split(ASCIILiteral(" "), responseVector);
> 
> String {

This is a problem with the style checker. This isn't a scope definition, it's a brace-initialization. Nobody is writing `String (response.data(), response.size())`.

[Zan Dobersek]

Created attachment 300303 [details]
Patch for landing

Skipped the layout test, addressed review feedback.

[Jer Noble]

Late to the party here, but this all LGTM. Thanks!

[Zan Dobersek]

Comment on attachment 300303 [details]
Patch for landing

Clearing flags on attachment: 300303

Committed r211550: <http://trac.webkit.org/changeset/211550>

[Zan Dobersek]

All reviewed patches have been landed.  Closing bug.