Summary: | Fix CMSampleBuffer leak in MediaSampleAVFObjC::createNonDisplayingCopy(). | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Andreas Kling <kling> | ||||
Component: | Media | Assignee: | Andreas Kling <kling> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue | ||||
Priority: | P2 | ||||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Andreas Kling
2017-01-30 17:34:46 PST
Created attachment 300168 [details]
Patch
Comment on attachment 300168 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=300168&action=review > Source/WebCore/platform/graphics/avfoundation/objc/MediaSampleAVFObjC.mm:232 > - return MediaSampleAVFObjC::create(newSampleBuffer, m_id); > + return MediaSampleAVFObjC::create(adoptCF(newSampleBuffer).get(), m_id); This is fine, but we could avoid some retain count churn by changing MediaSampleAVFObjc::create() to take a RetainPtr&& Comment on attachment 300168 [details] Patch Clearing flags on attachment: 300168 Committed r211399: <http://trac.webkit.org/changeset/211399> All reviewed patches have been landed. Closing bug. |