Bug 167599

Summary: Executive default error handler should log command output
Product: WebKit Reporter: Jonathan Bedard <jbedard>
Component: Tools / TestsAssignee: Jonathan Bedard <jbedard>
Status: RESOLVED INVALID    
Severity: Normal CC: commit-queue, glenn, lforschler
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Jonathan Bedard
Reported 2017-01-30 12:49:54 PST
Currently, the Executive's default error handler only prints out the exit code of the command which was run. At the very least, the debug log should contain the command output from the failed command.
Attachments
Patch (1.14 KB, patch)
2017-01-30 12:51 PST, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jonathan Bedard
Comment 1 2017-01-30 12:51:37 PST
Created attachment 300135 [details] Patch
Daniel Bates
Comment 2 2017-01-30 13:03:57 PST
Comment on attachment 300135 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=300135&action=review > Tools/Scripts/webkitpy/common/system/executive.py:377 > + _log.debug(error.message_with_output()) Is it necessary to do this general? If we need logging to debug an issue can we be more surgical and use a custom error handler that does this logging for the run_command() we want to log? I do not think we want logging as part of the default error handler as such output could be large.
Note You need to log in before you can comment on or make changes to this bug.