Bug 167542

Summary: Add User Timing Experimental Feature
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: WebCore Misc.Assignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, buildbot, cdumez, commit-queue, dino, esprehn+autocc, joepeck, kondapallykalyan, rniwa, simon.fraser, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
[PATCH] Proposed Fix - User Timing Experimental Feature
none
[PATCH] Proposed Fix - User Timing Experimental Feature
rniwa: review+, buildbot: commit-queue-
[PATCH] Proposed Fix - Import web-platform-tests/user-timing
rniwa: review+, buildbot: commit-queue-
[PATCH] For Bots - All Necessary Parts
none
Archive of layout-test-results from ews103 for mac-elcapitan
none
Archive of layout-test-results from ews106 for mac-elcapitan-wk2
none
Archive of layout-test-results from ews104 for mac-elcapitan-wk2
none
Archive of layout-test-results from ews117 for mac-elcapitan
none
Archive of layout-test-results from ews125 for ios-simulator-wk2
none
[PATCH] For Bots none

Description Joseph Pecoraro 2017-01-27 22:46:20 PST
Summary:
Add User Timing Experimental Feature

https://w3c.github.io/user-timing/

In the hierarchy of Performance Specs (Performance Timeline, User Timing, Resource Timing, Navigation Timing) User Timing is the most basic. It allows testing the fundamentals (PerformanceEntry, Extended Performance APIs) before moving on to the next phases (PerformanceObserver, reworking ResourceTiming + NavigationTiming on top of PerformanceEntry).
Comment 1 Joseph Pecoraro 2017-01-27 22:47:00 PST
<rdar://problem/22746307>
Comment 2 Joseph Pecoraro 2017-01-27 22:56:46 PST
Created attachment 299998 [details]
[PATCH] Proposed Fix - User Timing Experimental Feature
Comment 3 Joseph Pecoraro 2017-01-27 23:00:32 PST
Created attachment 300000 [details]
[PATCH] Proposed Fix - User Timing Experimental Feature
Comment 4 Joseph Pecoraro 2017-01-27 23:01:17 PST
Created attachment 300001 [details]
[PATCH] Proposed Fix - Import web-platform-tests/user-timing
Comment 5 Ryosuke Niwa 2017-01-27 23:01:29 PST
Comment on attachment 300000 [details]
[PATCH] Proposed Fix - User Timing Experimental Feature

r=me assuming it passes EWS.
Comment 6 Joseph Pecoraro 2017-01-27 23:03:08 PST
Created attachment 300002 [details]
[PATCH] For Bots - All Necessary Parts
Comment 7 Ryosuke Niwa 2017-01-27 23:05:19 PST
Comment on attachment 300001 [details]
[PATCH] Proposed Fix - Import web-platform-tests/user-timing

View in context: https://bugs.webkit.org/attachment.cgi?id=300001&action=review

rs=me

> LayoutTests/imported/w3c/resources/ImportExpectations:287
> -web-platform-tests/user-timing [ Skip ]
> +#web-platform-tests/user-timing [ Pass ]

Why is this commented out?
Comment 8 Joseph Pecoraro 2017-01-27 23:55:01 PST
Comment on attachment 300001 [details]
[PATCH] Proposed Fix - Import web-platform-tests/user-timing

View in context: https://bugs.webkit.org/attachment.cgi?id=300001&action=review

>> LayoutTests/imported/w3c/resources/ImportExpectations:287
>> +#web-platform-tests/user-timing [ Pass ]
> 
> Why is this commented out?

This is the style of all of the imported directories. Youenn would know why, I didn't ask =)
Comment 9 Build Bot 2017-01-28 00:02:59 PST
Comment on attachment 300001 [details]
[PATCH] Proposed Fix - Import web-platform-tests/user-timing

Attachment 300001 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2962302

New failing tests:
imported/w3c/web-platform-tests/user-timing/test_user_timing_mark_and_measure_exception_when_invoke_with_timing_attributes.html
imported/w3c/web-platform-tests/user-timing/test_user_timing_measure_navigation_timing.html
imported/w3c/web-platform-tests/user-timing/test_user_timing_mark_and_measure_exception_when_invoke_without_parameter.html
imported/w3c/web-platform-tests/user-timing/test_user_timing_clear_marks.html
imported/w3c/web-platform-tests/user-timing/test_user_timing_entry_type.html
imported/w3c/web-platform-tests/user-timing/test_user_timing_clear_measures.html
imported/w3c/web-platform-tests/user-timing/test_user_timing_exists.html
imported/w3c/web-platform-tests/user-timing/test_user_timing_mark_exceptions.html
imported/w3c/web-platform-tests/user-timing/test_user_timing_mark.html
imported/w3c/web-platform-tests/user-timing/test_user_timing_measure.html
imported/w3c/web-platform-tests/user-timing/test_user_timing_measure_exceptions.html
imported/w3c/web-platform-tests/user-timing/idlharness.html
Comment 10 Build Bot 2017-01-28 00:03:04 PST
Created attachment 300004 [details]
Archive of layout-test-results from ews103 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 11 Joseph Pecoraro 2017-01-28 00:07:09 PST
Yep, I need to update js/dom/global-constructors-attributes.html before landing.
Comment 12 Build Bot 2017-01-28 00:07:27 PST
Comment on attachment 300001 [details]
[PATCH] Proposed Fix - Import web-platform-tests/user-timing

Attachment 300001 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2962309

New failing tests:
imported/w3c/web-platform-tests/user-timing/test_user_timing_mark_and_measure_exception_when_invoke_with_timing_attributes.html
imported/w3c/web-platform-tests/user-timing/test_user_timing_measure_navigation_timing.html
imported/w3c/web-platform-tests/user-timing/test_user_timing_mark_and_measure_exception_when_invoke_without_parameter.html
imported/w3c/web-platform-tests/user-timing/test_user_timing_clear_marks.html
imported/w3c/web-platform-tests/user-timing/test_user_timing_entry_type.html
imported/w3c/web-platform-tests/user-timing/test_user_timing_clear_measures.html
imported/w3c/web-platform-tests/user-timing/test_user_timing_exists.html
imported/w3c/web-platform-tests/user-timing/test_user_timing_mark_exceptions.html
imported/w3c/web-platform-tests/user-timing/test_user_timing_mark.html
imported/w3c/web-platform-tests/user-timing/test_user_timing_measure.html
imported/w3c/web-platform-tests/user-timing/test_user_timing_measure_exceptions.html
imported/w3c/web-platform-tests/user-timing/idlharness.html
Comment 13 Build Bot 2017-01-28 00:07:32 PST
Created attachment 300005 [details]
Archive of layout-test-results from ews106 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6
Comment 14 Build Bot 2017-01-28 00:12:44 PST
Comment on attachment 300000 [details]
[PATCH] Proposed Fix - User Timing Experimental Feature

Attachment 300000 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2962303

New failing tests:
js/dom/global-constructors-attributes.html
Comment 15 Build Bot 2017-01-28 00:12:49 PST
Created attachment 300007 [details]
Archive of layout-test-results from ews104 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6
Comment 16 Build Bot 2017-01-28 00:14:18 PST
Comment on attachment 300001 [details]
[PATCH] Proposed Fix - Import web-platform-tests/user-timing

Attachment 300001 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2962320

New failing tests:
imported/w3c/web-platform-tests/user-timing/test_user_timing_mark_and_measure_exception_when_invoke_with_timing_attributes.html
imported/w3c/web-platform-tests/user-timing/test_user_timing_measure_navigation_timing.html
imported/w3c/web-platform-tests/user-timing/test_user_timing_mark_and_measure_exception_when_invoke_without_parameter.html
imported/w3c/web-platform-tests/user-timing/test_user_timing_clear_marks.html
imported/w3c/web-platform-tests/user-timing/test_user_timing_entry_type.html
imported/w3c/web-platform-tests/user-timing/test_user_timing_clear_measures.html
imported/w3c/web-platform-tests/user-timing/test_user_timing_exists.html
imported/w3c/web-platform-tests/user-timing/test_user_timing_mark_exceptions.html
imported/w3c/web-platform-tests/user-timing/test_user_timing_mark.html
imported/w3c/web-platform-tests/user-timing/test_user_timing_measure.html
imported/w3c/web-platform-tests/user-timing/test_user_timing_measure_exceptions.html
imported/w3c/web-platform-tests/user-timing/idlharness.html
Comment 17 Build Bot 2017-01-28 00:14:23 PST
Created attachment 300008 [details]
Archive of layout-test-results from ews117 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 18 Build Bot 2017-01-28 00:18:07 PST
Comment on attachment 300001 [details]
[PATCH] Proposed Fix - Import web-platform-tests/user-timing

Attachment 300001 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2962314

New failing tests:
imported/w3c/web-platform-tests/user-timing/test_user_timing_mark_and_measure_exception_when_invoke_with_timing_attributes.html
imported/w3c/web-platform-tests/user-timing/test_user_timing_measure_navigation_timing.html
imported/w3c/web-platform-tests/user-timing/test_user_timing_measure.html
imported/w3c/web-platform-tests/user-timing/test_user_timing_mark_and_measure_exception_when_invoke_without_parameter.html
imported/w3c/web-platform-tests/user-timing/idlharness.html
imported/w3c/web-platform-tests/user-timing/test_user_timing_clear_marks.html
imported/w3c/web-platform-tests/user-timing/test_user_timing_clear_measures.html
imported/w3c/web-platform-tests/user-timing/test_user_timing_exists.html
imported/w3c/web-platform-tests/user-timing/test_user_timing_mark.html
imported/w3c/web-platform-tests/user-timing/test_user_timing_mark_exceptions.html
imported/w3c/web-platform-tests/user-timing/test_user_timing_measure_exceptions.html
imported/w3c/web-platform-tests/user-timing/test_user_timing_entry_type.html
Comment 19 Build Bot 2017-01-28 00:18:11 PST
Created attachment 300009 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6
Comment 20 Joseph Pecoraro 2017-01-28 00:26:02 PST
Created attachment 300010 [details]
[PATCH] For Bots
Comment 21 Joseph Pecoraro 2017-01-28 01:29:53 PST
<https://trac.webkit.org/changeset/211332> Experimental Flag
<https://trac.webkit.org/changeset/211333> web-platform-tests/user-timing