| Summary: | Simple line layout: Do not bail out on -webkit-line-box-contain: glyphs unless text overflows vertically. | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | zalan <zalan> |
| Component: | Layout and Rendering | Assignee: | zalan <zalan> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bfulgham, buildbot, commit-queue, esprehn+autocc, glenn, koivisto, kondapallykalyan, mmaxfield, rniwa, simon.fraser, zalan |
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Attachments: | |||
|
Description
zalan
2017-01-26 18:21:51 PST
Created attachment 299901 [details]
Patch
Comment on attachment 299901 [details] Patch Attachment 299901 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/2956209 New failing tests: fast/block/lineboxcontain/glyphs.html Created attachment 299906 [details]
Archive of layout-test-results from ews100 for mac-elcapitan
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Comment on attachment 299901 [details] Patch Attachment 299901 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/2956224 New failing tests: fast/block/lineboxcontain/glyphs.html Created attachment 299907 [details]
Archive of layout-test-results from ews107 for mac-elcapitan-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6
Comment on attachment 299901 [details] Patch Attachment 299901 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/2956223 New failing tests: fast/block/lineboxcontain/glyphs.html Created attachment 299908 [details]
Archive of layout-test-results from ews116 for mac-elcapitan
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Comment on attachment 299901 [details] Patch Attachment 299901 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/2956229 New failing tests: fast/block/lineboxcontain/glyphs.html Created attachment 299909 [details]
Archive of layout-test-results from ews126 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.6
Comment on attachment 299901 [details]
Patch
It looks like 'contain glyphs' needs some painting adjustment (baseline shift?).
Created attachment 299936 [details]
Patch
Created attachment 299944 [details]
Patch
Comment on attachment 299944 [details] Patch Clearing flags on attachment: 299944 Committed r211292: <http://trac.webkit.org/changeset/211292> All reviewed patches have been landed. Closing bug. |