Bug 167481

Summary:

Simple line layout: Do not bail out on -webkit-line-box-contain: glyphs unless text overflows vertically.

Product:

WebKit

Reporter:

alan <zalan>

Component:

Layout and Rendering

Assignee:

alan <zalan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, buildbot, commit-queue, esprehn+autocc, glenn, koivisto, kondapallykalyan, mmaxfield, rniwa, simon.fraser, zalan

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews100 for mac-elcapitan	none
Archive of layout-test-results from ews107 for mac-elcapitan-wk2	none
Archive of layout-test-results from ews116 for mac-elcapitan	none
Archive of layout-test-results from ews126 for ios-simulator-wk2	none
Patch	none
Patch	none

alan

Reported 2017-01-26 18:21:51 PST

<rdar://problem/30180150>

Attachments
Patch (9.23 KB, patch) 2017-01-26 20:13 PST, alan	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews100 for mac-elcapitan (1.02 MB, application/zip) 2017-01-26 21:15 PST, Build Bot	no flags	Details
Archive of layout-test-results from ews107 for mac-elcapitan-wk2 (898.79 KB, application/zip) 2017-01-26 21:18 PST, Build Bot	no flags	Details
Archive of layout-test-results from ews116 for mac-elcapitan (1.69 MB, application/zip) 2017-01-26 21:22 PST, Build Bot	no flags	Details
Archive of layout-test-results from ews126 for ios-simulator-wk2 (3.65 MB, application/zip) 2017-01-26 21:29 PST, Build Bot	no flags	Details
Patch (9.45 KB, patch) 2017-01-27 09:40 PST, alan	no flags	Details Formatted Diff Diff
Patch (9.40 KB, patch) 2017-01-27 11:02 PST, alan	no flags	Details Formatted Diff Diff
Show Obsolete (6) View All Add attachment proposed patch, testcase, etc.

alan

Comment 1 2017-01-26 20:13:55 PST

Created attachment 299901 [details] Patch

Build Bot

Comment 2 2017-01-26 21:14:56 PST

Comment on attachment 299901 [details] Patch Attachment 299901 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/2956209 New failing tests: fast/block/lineboxcontain/glyphs.html

Build Bot

Comment 3 2017-01-26 21:15:00 PST

Created attachment 299906 [details] Archive of layout-test-results from ews100 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Build Bot

Comment 4 2017-01-26 21:17:58 PST

Comment on attachment 299901 [details] Patch Attachment 299901 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/2956224 New failing tests: fast/block/lineboxcontain/glyphs.html

Build Bot

Comment 5 2017-01-26 21:18:02 PST

Created attachment 299907 [details] Archive of layout-test-results from ews107 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6

Build Bot

Comment 6 2017-01-26 21:22:54 PST

Comment on attachment 299901 [details] Patch Attachment 299901 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/2956223 New failing tests: fast/block/lineboxcontain/glyphs.html

Build Bot

Comment 7 2017-01-26 21:22:58 PST

Created attachment 299908 [details] Archive of layout-test-results from ews116 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews116 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Build Bot

Comment 8 2017-01-26 21:29:46 PST

Comment on attachment 299901 [details] Patch Attachment 299901 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/2956229 New failing tests: fast/block/lineboxcontain/glyphs.html

Build Bot

Comment 9 2017-01-26 21:29:50 PST

Created attachment 299909 [details] Archive of layout-test-results from ews126 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews126 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.6

alan

Comment 10 2017-01-26 22:11:12 PST

Comment on attachment 299901 [details] Patch It looks like 'contain glyphs' needs some painting adjustment (baseline shift?).

alan

Comment 11 2017-01-27 09:40:39 PST

Created attachment 299936 [details] Patch

alan

Comment 12 2017-01-27 11:02:03 PST

Created attachment 299944 [details] Patch

WebKit Commit Bot

Comment 13 2017-01-27 11:25:46 PST

Comment on attachment 299944 [details] Patch Clearing flags on attachment: 299944 Committed r211292: <http://trac.webkit.org/changeset/211292>

WebKit Commit Bot

Comment 14 2017-01-27 11:25:54 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.