Summary: | Web Inspector: iOS: Memory timeline shows impossible values for Page size (underflowed) | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Joseph Pecoraro <joepeck> | ||||
Component: | Web Inspector | Assignee: | Joseph Pecoraro <joepeck> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | barraclough, bfulgham, commit-queue, ggaren, inspector-bugzilla-changes, joepeck, kling, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Joseph Pecoraro
2017-01-26 15:09:36 PST
This developer forum post seems to offer the most accurate information: https://forums.developer.apple.com/thread/47532 Namely: These should all match: - getpagesize - sysconf(_SC_PAGESIZE) - vm_page_size As: • 16 KiB on 64-bit ARM platforms • 4 KiB on everything else However, "various low-level Mach APIs (which we are using here) continue to work in terms of 4 KiB pages." You can get that value using vm_kernel_page_size. --- So this ends up matching bmalloc's vmPageSizePhysical(): > inline size_t vmPageSizePhysical() > { > #if (BPLATFORM(IOS) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 100000) > return vm_kernel_page_size; > #else > static size_t cached; > if (!cached) > cached = sysconf(_SC_PAGESIZE); > return cached; > #endif > } Created attachment 299862 [details]
[PATCH] Proposed Fix
Comment on attachment 299862 [details]
[PATCH] Proposed Fix
r=me!
Comment on attachment 299862 [details] [PATCH] Proposed Fix Clearing flags on attachment: 299862 Committed r211241: <http://trac.webkit.org/changeset/211241> All reviewed patches have been landed. Closing bug. |