Bug 167443 – Add infrastructure to support data interaction in WebKit2

• Component: WebKit Misc.
• Status: RESOLVED FIXED

[Wenson Hsieh]

Add infrastructure to support data interaction in WebKit2

[Wenson Hsieh]

Created attachment 299787 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 299787 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=299787&action=review

> Source/WebCore/page/Page.cpp:2170
> +    if (auto selectedRange = currentSelection.toNormalizedRange()) {
> +        Vector<SelectionRect> selectionRects;
> +        selectedRange->collectSelectionRects(selectionRects);
> +        for (auto selectionRect : selectionRects) {
> +            if (FloatRect(selectionRect.rect()).contains(position))
> +                return true;
> +        }

Is "position" in the same coordinate space as the rects? Did you test with zooming, iframes etc?

[Wenson Hsieh]

Comment on attachment 299787 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=299787&action=review

Thank you!

>> Source/WebCore/page/Page.cpp:2170
>> +        }
> 
> Is "position" in the same coordinate space as the rects? Did you test with zooming, iframes etc?

I believe so -- the position here is the same one set by calling into Frame::nodeRespondingToClickEvents, which appears to be in document coordinates. I have tested scaling, but not frames -- I will try that case out as well.

[Wenson Hsieh]

Created attachment 299789 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 299789 [details]
Patch for landing

Rejecting attachment 299789 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 299789, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!.

Full output: http://webkit-queues.webkit.org/results/2950105

[Wenson Hsieh]

Created attachment 299790 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 299790 [details]
Patch for landing

Clearing flags on attachment: 299790

Committed r211199: <http://trac.webkit.org/changeset/211199>

[Wenson Hsieh]

<rdar://problem/30107775>