Bug 167438

Summary:

[WebRTC] Add support for incoming and outgoing libwebrtc audio tracks

Product:

WebKit

Reporter:

youenn fablet <youennf>

Component:

WebCore Misc.

Assignee:

youenn fablet <youennf>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, eric.carlson, jer.noble

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch for landing	none

youenn fablet

Reported 2017-01-25 16:26:55 PST

Or at least a skeleton for them

Attachments
Patch (23.72 KB, patch) 2017-01-25 16:31 PST, youenn fablet	no flags	Details Formatted Diff Diff
Patch for landing (23.78 KB, patch) 2017-01-25 17:08 PST, youenn fablet	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

youenn fablet

Comment 1 2017-01-25 16:31:50 PST

Created attachment 299764 [details] Patch

Eric Carlson

Comment 2 2017-01-25 16:42:44 PST

Comment on attachment 299764 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=299764&action=review > Source/WebCore/ChangeLog:3 > + [WebRTC] Add support for libwebrtc audio incoming and outgoing video tracks Nit: I think you mean "outgoing audio tracks", but something "Add support for incoming and outgoing libwebrtc audio tracks" might be clearer.

youenn fablet

Comment 3 2017-01-25 16:46:14 PST

Thanks for the review. > Nit: I think you mean "outgoing audio tracks", but something "Add support > for incoming and outgoing libwebrtc audio tracks" might be clearer. That is much clearer indeed.

youenn fablet

Comment 4 2017-01-25 17:08:24 PST

Created attachment 299772 [details] Patch for landing

WebKit Commit Bot

Comment 5 2017-01-25 17:45:03 PST

Comment on attachment 299772 [details] Patch for landing Clearing flags on attachment: 299772 Committed r211191: <http://trac.webkit.org/changeset/211191>

WebKit Commit Bot

Comment 6 2017-01-25 17:45:06 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.