Bug 167432

Summary:

[WebRTC] Add support for libwebrtc video incoming and outgoing video tracks

Product:

WebKit

Reporter:

youenn fablet <youennf>

Component:

WebCore Misc.

Assignee:

youenn fablet <youennf>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, eric.carlson, jer.noble

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

youenn fablet

Reported 2017-01-25 14:09:21 PST

[WebRTC] Add support for libwebrtc video incoming and outgoing video tracks

Attachments
Patch (23.65 KB, patch) 2017-01-25 14:55 PST, youenn fablet	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

youenn fablet

Comment 1 2017-01-25 14:55:44 PST

Created attachment 299751 [details] Patch

WebKit Commit Bot

Comment 2 2017-01-25 14:58:25 PST

Attachment 299751 [details] did not pass style-queue: ERROR: Source/WebCore/platform/mediastream/mac/RealtimeOutgoingVideoSource.h:56: is_screencast is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/platform/mediastream/mac/RealtimeOutgoingVideoSource.h:57: needs_denoising is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Total errors found: 2 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.

WebKit Commit Bot

Comment 3 2017-01-25 16:33:09 PST

Comment on attachment 299751 [details] Patch Clearing flags on attachment: 299751 Committed r211177: <http://trac.webkit.org/changeset/211177>

WebKit Commit Bot

Comment 4 2017-01-25 16:33:13 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.