| Summary: | Refactor drag and drop implementation on Mac | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Wenson Hsieh <wenson_hsieh> | ||||||||||||||
| Component: | DOM | Assignee: | Wenson Hsieh <wenson_hsieh> | ||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||
| Severity: | Normal | CC: | bdakin, cdumez, commit-queue, dbates, enrica, esprehn+autocc, kangil.han | ||||||||||||||
| Priority: | P2 | ||||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||||
| Hardware: | Mac | ||||||||||||||||
| OS: | macOS 10.12 | ||||||||||||||||
| Attachments: |
|
||||||||||||||||
|
Description
Wenson Hsieh
2017-01-25 13:01:01 PST
Created attachment 299756 [details]
Patch
Attachment 299756 [details] did not pass style-queue:
ERROR: Source/WebCore/platform/mac/DragDataMac.mm:96: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4]
Total errors found: 1 in 21 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 299759 [details]
Patch
Created attachment 299760 [details]
Address build failures.
Attachment 299760 [details] did not pass style-queue:
ERROR: Source/WebCore/platform/mac/DragDataMac.mm:96: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4]
Total errors found: 1 in 21 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 299765 [details]
Another attempt to address build failures
Attachment 299765 [details] did not pass style-queue:
ERROR: Source/WebCore/platform/mac/DragDataMac.mm:96: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4]
Total errors found: 1 in 20 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 299765 [details] Another attempt to address build failures View in context: https://bugs.webkit.org/attachment.cgi?id=299765&action=review > Source/WebCore/platform/ios/DragImageIOS.mm:36 > +#pragma clang diagnostic pop would it be possible to have the pragmas inside the imported file? Comment on attachment 299765 [details] Another attempt to address build failures View in context: https://bugs.webkit.org/attachment.cgi?id=299765&action=review Thank you Enrica! >> Source/WebCore/platform/ios/DragImageIOS.mm:36 >> +#pragma clang diagnostic pop > > would it be possible to have the pragmas inside the imported file? Yes! I'll do that. Created attachment 299776 [details]
Patch for landing
Comment on attachment 299776 [details] Patch for landing Rejecting attachment 299776 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 299776, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: mm patching file Source/WebKit/mac/WebView/WebFrameInternal.h patching file Source/WebKit/mac/WebView/WebHTMLView.mm patching file Source/WebKit/mac/WebView/WebView.mm patching file Source/WebKit2/Shared/WebCoreArgumentCoders.cpp patching file Source/WebKit2/UIProcess/Cocoa/WebPageProxyCocoa.mm patching file Source/WebKit2/WebProcess/WebCoreSupport/mac/WebDragClientMac.mm Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.webkit.org/results/2949534 Created attachment 299777 [details]
Patch for landing
Comment on attachment 299777 [details] Patch for landing Clearing flags on attachment: 299777 Committed r211192: <http://trac.webkit.org/changeset/211192> |