Bug 167427

Summary:

Refactor drag and drop implementation on Mac

Product:

WebKit

Reporter:

Wenson Hsieh <wenson_hsieh>

Component:

DOM

Assignee:

Wenson Hsieh <wenson_hsieh>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bdakin, cdumez, commit-queue, dbates, enrica, esprehn+autocc, kangil.han

Priority:

Version:

WebKit Nightly Build

Hardware:

Mac

OS:

macOS 10.12

Attachments:

Description	Flags
Patch	none
Patch	none
Address build failures.	none
Another attempt to address build failures	enrica: review+
Patch for landing	commit-queue: commit-queue-
Patch for landing	none

Wenson Hsieh

Reported 2017-01-25 13:01:01 PST

Refactor drag and drop implementation in WebCore

Attachments
Patch (26.01 KB, patch) 2017-01-25 15:53 PST, Wenson Hsieh	no flags	Details Formatted Diff Diff
Patch (46.34 KB, patch) 2017-01-25 16:08 PST, Wenson Hsieh	no flags	Details Formatted Diff Diff
Address build failures. (25.50 KB, patch) 2017-01-25 16:09 PST, Wenson Hsieh	no flags	Details Formatted Diff Diff
Another attempt to address build failures (24.98 KB, patch) 2017-01-25 16:36 PST, Wenson Hsieh	enrica: review+	Details Formatted Diff Diff
Patch for landing (47.33 KB, patch) 2017-01-25 17:22 PST, Wenson Hsieh	commit-queue: commit-queue-	Details Formatted Diff Diff
Patch for landing (26.48 KB, patch) 2017-01-25 17:24 PST, Wenson Hsieh	no flags	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

Wenson Hsieh

Comment 1 2017-01-25 15:53:44 PST

Created attachment 299756 [details] Patch

WebKit Commit Bot

Comment 2 2017-01-25 15:56:57 PST

Attachment 299756 [details] did not pass style-queue: ERROR: Source/WebCore/platform/mac/DragDataMac.mm:96: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] Total errors found: 1 in 21 files If any of these errors are false positives, please file a bug against check-webkit-style.

Wenson Hsieh

Comment 3 2017-01-25 16:08:14 PST

Created attachment 299759 [details] Patch

Wenson Hsieh

Comment 4 2017-01-25 16:09:51 PST

Created attachment 299760 [details] Address build failures.

WebKit Commit Bot

Comment 5 2017-01-25 16:11:09 PST

Attachment 299760 [details] did not pass style-queue: ERROR: Source/WebCore/platform/mac/DragDataMac.mm:96: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] Total errors found: 1 in 21 files If any of these errors are false positives, please file a bug against check-webkit-style.

Wenson Hsieh

Comment 6 2017-01-25 16:36:21 PST

Created attachment 299765 [details] Another attempt to address build failures

WebKit Commit Bot

Comment 7 2017-01-25 16:39:20 PST

Attachment 299765 [details] did not pass style-queue: ERROR: Source/WebCore/platform/mac/DragDataMac.mm:96: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] Total errors found: 1 in 20 files If any of these errors are false positives, please file a bug against check-webkit-style.

Enrica Casucci

Comment 8 2017-01-25 16:57:41 PST

Comment on attachment 299765 [details] Another attempt to address build failures View in context: https://bugs.webkit.org/attachment.cgi?id=299765&action=review > Source/WebCore/platform/ios/DragImageIOS.mm:36 > +#pragma clang diagnostic pop would it be possible to have the pragmas inside the imported file?

Wenson Hsieh

Comment 9 2017-01-25 16:59:02 PST

Comment on attachment 299765 [details] Another attempt to address build failures View in context: https://bugs.webkit.org/attachment.cgi?id=299765&action=review Thank you Enrica! >> Source/WebCore/platform/ios/DragImageIOS.mm:36 >> +#pragma clang diagnostic pop > > would it be possible to have the pragmas inside the imported file? Yes! I'll do that.

Wenson Hsieh

Comment 10 2017-01-25 17:22:05 PST

Created attachment 299776 [details] Patch for landing

WebKit Commit Bot

Comment 11 2017-01-25 17:23:46 PST

Comment on attachment 299776 [details] Patch for landing Rejecting attachment 299776 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 299776, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: mm patching file Source/WebKit/mac/WebView/WebFrameInternal.h patching file Source/WebKit/mac/WebView/WebHTMLView.mm patching file Source/WebKit/mac/WebView/WebView.mm patching file Source/WebKit2/Shared/WebCoreArgumentCoders.cpp patching file Source/WebKit2/UIProcess/Cocoa/WebPageProxyCocoa.mm patching file Source/WebKit2/WebProcess/WebCoreSupport/mac/WebDragClientMac.mm Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.webkit.org/results/2949534

Wenson Hsieh

Comment 12 2017-01-25 17:24:33 PST

Created attachment 299777 [details] Patch for landing

WebKit Commit Bot

Comment 13 2017-01-25 18:02:48 PST

Comment on attachment 299777 [details] Patch for landing Clearing flags on attachment: 299777 Committed r211192: <http://trac.webkit.org/changeset/211192>

Wenson Hsieh

Comment 14 2017-01-28 12:25:51 PST

<rdar://problem/30107775>

Note You need to log in before you can comment on or make changes to this bug.