Bug 167424

Summary:

classInfo should take a VM so it is not materialized from the object on each call

Product:

WebKit

Reporter:

Keith Miller <keith_miller>

Component:

New Bugs

Assignee:

Keith Miller <keith_miller>

Status:

NEW

Severity:

Normal

CC:

buildbot, commit-queue, rniwa

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Archive of layout-test-results from ews100 for mac-elcapitan	none
Archive of layout-test-results from ews114 for mac-elcapitan	none
Archive of layout-test-results from ews107 for mac-elcapitan-wk2	none
Archive of layout-test-results from ews125 for ios-simulator-wk2	none
Patch	none
Patch	none
Archive of layout-test-results from ews102 for mac-elcapitan	none
Archive of layout-test-results from ews116 for mac-elcapitan	none
Archive of layout-test-results from ews107 for mac-elcapitan-wk2	none
Patch	none
Patch	none
Patch	none
Patch for landing	commit-queue: commit-queue-

Keith Miller

Reported 2017-01-25 10:34:18 PST

classInfo should take a VM so it is not materialized from the object on each load

Attachments
Patch (619.35 KB, patch) 2017-01-25 10:57 PST, Keith Miller	no flags	Details Formatted Diff Diff
Patch (619.49 KB, patch) 2017-01-25 11:25 PST, Keith Miller	no flags	Details Formatted Diff Diff
Patch (619.50 KB, patch) 2017-01-25 11:38 PST, Keith Miller	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews100 for mac-elcapitan (902.24 KB, application/zip) 2017-01-25 12:53 PST, Build Bot	no flags	Details
Archive of layout-test-results from ews114 for mac-elcapitan (960.82 KB, application/zip) 2017-01-25 12:53 PST, Build Bot	no flags	Details
Archive of layout-test-results from ews107 for mac-elcapitan-wk2 (1.04 MB, application/zip) 2017-01-25 12:57 PST, Build Bot	no flags	Details
Archive of layout-test-results from ews125 for ios-simulator-wk2 (deleted) 2017-01-25 13:04 PST, Build Bot	no flags	Details
Patch (619.91 KB, patch) 2017-01-25 16:38 PST, Keith Miller	no flags	Details Formatted Diff Diff
Patch (620.75 KB, patch) 2017-01-25 16:55 PST, Keith Miller	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews102 for mac-elcapitan (892.05 KB, application/zip) 2017-01-25 18:20 PST, Build Bot	no flags	Details
Archive of layout-test-results from ews116 for mac-elcapitan (1.71 MB, application/zip) 2017-01-25 18:33 PST, Build Bot	no flags	Details
Archive of layout-test-results from ews107 for mac-elcapitan-wk2 (898.45 KB, application/zip) 2017-01-25 18:46 PST, Build Bot	no flags	Details
Patch (622.01 KB, patch) 2017-01-26 11:40 PST, Keith Miller	no flags	Details Formatted Diff Diff
Patch (623.71 KB, patch) 2017-01-26 12:11 PST, Keith Miller	no flags	Details Formatted Diff Diff
Patch (672.79 KB, patch) 2017-01-26 14:30 PST, Keith Miller	no flags	Details Formatted Diff Diff
Patch for landing (673.03 KB, patch) 2017-01-26 16:38 PST, Keith Miller	commit-queue: commit-queue-	Details Formatted Diff Diff
Show Obsolete (8) View All Add attachment proposed patch, testcase, etc.

Keith Miller

Comment 1 2017-01-25 10:57:48 PST

Created attachment 299714 [details] Patch

Keith Miller

Comment 2 2017-01-25 11:25:03 PST

Created attachment 299719 [details] Patch

Keith Miller

Comment 3 2017-01-25 11:38:49 PST

Created attachment 299722 [details] Patch

Build Bot

Comment 4 2017-01-25 12:53:53 PST

Comment on attachment 299722 [details] Patch Attachment 299722 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/2948059 Number of test failures exceeded the failure limit.

Build Bot

Comment 5 2017-01-25 12:53:55 PST

Created attachment 299730 [details] Archive of layout-test-results from ews100 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Build Bot

Comment 6 2017-01-25 12:53:56 PST

Created attachment 299731 [details] Archive of layout-test-results from ews114 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews114 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Build Bot

Comment 7 2017-01-25 12:56:58 PST

Comment on attachment 299722 [details] Patch Attachment 299722 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/2948080 Number of test failures exceeded the failure limit.

Build Bot

Comment 8 2017-01-25 12:57:01 PST

Created attachment 299733 [details] Archive of layout-test-results from ews107 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6

Build Bot

Comment 9 2017-01-25 13:03:57 PST

Comment on attachment 299722 [details] Patch Attachment 299722 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/2948075 Number of test failures exceeded the failure limit.

Build Bot

Comment 10 2017-01-25 13:04:01 PST

Created attachment 299734 [details] Archive of layout-test-results from ews125 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews125 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.6

Keith Miller

Comment 11 2017-01-25 16:38:27 PST

Created attachment 299766 [details] Patch

Keith Miller

Comment 12 2017-01-25 16:55:46 PST

Created attachment 299771 [details] Patch

Build Bot

Comment 13 2017-01-25 18:20:20 PST

Comment on attachment 299771 [details] Patch Attachment 299771 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/2949578 New failing tests: inspector/dom/highlightNode.html inspector/console/addInspectedNode.html

Build Bot

Comment 14 2017-01-25 18:20:23 PST

Created attachment 299780 [details] Archive of layout-test-results from ews102 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Build Bot

Comment 15 2017-01-25 18:33:13 PST

Comment on attachment 299771 [details] Patch Attachment 299771 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/2949579 New failing tests: inspector/dom/highlightNode.html

Build Bot

Comment 16 2017-01-25 18:33:16 PST

Created attachment 299781 [details] Archive of layout-test-results from ews116 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews116 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Build Bot

Comment 17 2017-01-25 18:46:06 PST

Comment on attachment 299771 [details] Patch Attachment 299771 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/2949669 New failing tests: inspector/dom/highlightNode.html inspector/console/addInspectedNode.html

Build Bot

Comment 18 2017-01-25 18:46:10 PST

Created attachment 299783 [details] Archive of layout-test-results from ews107 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6

Keith Miller

Comment 19 2017-01-26 11:40:46 PST

Created attachment 299828 [details] Patch

Keith Miller

Comment 20 2017-01-26 12:11:17 PST

Created attachment 299833 [details] Patch

Keith Miller

Comment 21 2017-01-26 14:30:51 PST

Created attachment 299856 [details] Patch

WebKit Commit Bot

Comment 22 2017-01-26 16:08:55 PST

Comment on attachment 299856 [details] Patch Rejecting attachment 299856 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 299856, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: fs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ... Currently at 211234 = 2d3e6ad565f2e41cc15c21edee365768839aedff r211235 = bde3edc2dbc16a55bc0544cc4ab535275b16663d r211236 = 7532ca67eb9d6ba5a1988d7970769a061ba3b3ff r211237 = 239d20b45b1c03d9209eb24e63f76504b6429356 Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Full output: http://webkit-queues.webkit.org/results/2954958

Keith Miller

Comment 23 2017-01-26 16:38:06 PST

Created attachment 299877 [details] Patch for landing

WebKit Commit Bot

Comment 24 2017-01-26 17:01:14 PST

Comment on attachment 299877 [details] Patch for landing Rejecting attachment 299877 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'build', '--no-clean', '--no-update', '--build-style=release', '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: ta/EWS/WebKit/Source/JavaScriptCore/dfg/DFGFlushFormat.cpp -o /Volumes/Data/EWS/WebKit/WebKitBuild/JavaScriptCore.build/Release/JavaScriptCore.build/Objects-normal/x86_64/DFGFlushFormat.o ** BUILD FAILED ** The following build commands failed: CompileC /Volumes/Data/EWS/WebKit/WebKitBuild/JavaScriptCore.build/Release/JavaScriptCore.build/Objects-normal/x86_64/DFGDesiredWeakReferences.o dfg/DFGDesiredWeakReferences.cpp normal x86_64 c++ com.apple.compilers.llvm.clang.1_0.compiler (1 failure) Full output: http://webkit-queues.webkit.org/results/2955130

Note You need to log in before you can comment on or make changes to this bug.