| Summary: | Atomics.store should return the int-converted value according to toInteger | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Filip Pizlo <fpizlo> | ||||
| Component: | JavaScriptCore | Assignee: | Filip Pizlo <fpizlo> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | commit-queue, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Attachments: |
|
||||||
|
Description
Filip Pizlo
2017-01-24 17:23:15 PST
Created attachment 299659 [details]
the patch
Comment on attachment 299659 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=299659&action=review > JSTests/stress/atomics-store-return.js:14 > +result = Atomics.store(a, 0, 4000000000); > if (result != 4000000000) > throw "Error: bad result: " + result; > +result = Atomics.store(a, 0, -4000000000); > +if (result != -4000000000) > + throw "Error: bad result: " + result; Can you add a valueOf test too? (In reply to comment #3) > Comment on attachment 299659 [details] > the patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=299659&action=review > > > JSTests/stress/atomics-store-return.js:14 > > +result = Atomics.store(a, 0, 4000000000); > > if (result != 4000000000) > > throw "Error: bad result: " + result; > > +result = Atomics.store(a, 0, -4000000000); > > +if (result != -4000000000) > > + throw "Error: bad result: " + result; > > Can you add a valueOf test too? Good idea. Will do. Landed in https://trac.webkit.org/changeset/211129 |