Bug 167396 – LayoutTest media/modern-media-controls/media-controller/media-controller-auto-hide-rewind-with-mouse-enter.html is a flaky failure

• Component: New Bugs
• Status: RESOLVED FIXED

[Ryan Haddad]

LayoutTest media/modern-media-controls/media-controller/media-controller-auto-hide-rewind-with-mouse-enter.html is a flaky failure

https://build.webkit.org/results/Apple%20El%20Capitan%20Release%20WK2%20(Tests)/r211112%20(12555)/results.html

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#tests=media%2Fmodern-media-controls%2Fmedia-controller%2Fmedia-controller-auto-hide-rewind-with-mouse-enter.html

--- /Volumes/Data/slave/elcapitan-release-tests-wk2/build/layout-test-results/media/modern-media-controls/media-controller/media-controller-auto-hide-rewind-with-mouse-enter-expected.txt
+++ /Volumes/Data/slave/elcapitan-release-tests-wk2/build/layout-test-results/media/modern-media-controls/media-controller/media-controller-auto-hide-rewind-with-mouse-enter-actual.txt
@@ -7,7 +7,7 @@
 PASS controlsBar.classList.contains('faded') is false
 
 Auto-hide timer has elapsed, controls bar should be faded.
-PASS controlsBar.classList.contains('faded') is true
+FAIL controlsBar.classList.contains('faded') should be true. Was false.
 
 Mouse moved over the media, controls bar should be visible.
 PASS controlsBar.classList.contains('faded') is false

[Ryan Haddad]

When I looked at this test yesterday, it had not failed since the 20th. It has failed 4 times since yesterday night.

[Antoine Quint]

This is tricky because this test, and a host of others, is timing-sensitive by design since it's testing the auto-hide timer. The test checks as close as possible to the auto-hide delay that the controls are still visible, and then again as soon as possible after the auto-hide delay has elapsed to check that the controls are no longer visible. So in certain cases, probably where the system is under pressure and timers run late, we get in cases where the check prior to the timer firing fails because we've actually run past auto-hide delay. We're going to have to find a different way to test this.

[Jon Lee]

When testing could we set the auto-hide timer to 0?

[Ryan Haddad]

Marked test as flaky in http://trac.webkit.org/projects/webkit/changeset/211157

[Radar WebKit Bug Importer]

<rdar://problem/30822447>

[Antoine Quint]

Created attachment 303281 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 303281 [details]
Patch

Clearing flags on attachment: 303281

Committed r213342: <http://trac.webkit.org/changeset/213342>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.