Summary: | LayoutTest media/modern-media-controls/media-controller/media-controller-auto-hide-rewind-with-mouse-enter.html is a flaky failure | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ryan Haddad <ryanhaddad> | ||||
Component: | New Bugs | Assignee: | Antoine Quint <graouts> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, graouts, jonlee, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | Other | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Ryan Haddad
2017-01-24 16:36:46 PST
When I looked at this test yesterday, it had not failed since the 20th. It has failed 4 times since yesterday night. This is tricky because this test, and a host of others, is timing-sensitive by design since it's testing the auto-hide timer. The test checks as close as possible to the auto-hide delay that the controls are still visible, and then again as soon as possible after the auto-hide delay has elapsed to check that the controls are no longer visible. So in certain cases, probably where the system is under pressure and timers run late, we get in cases where the check prior to the timer firing fails because we've actually run past auto-hide delay. We're going to have to find a different way to test this. When testing could we set the auto-hide timer to 0? Marked test as flaky in http://trac.webkit.org/projects/webkit/changeset/211157 Created attachment 303281 [details]
Patch
Comment on attachment 303281 [details] Patch Clearing flags on attachment: 303281 Committed r213342: <http://trac.webkit.org/changeset/213342> All reviewed patches have been landed. Closing bug. |