Bug 167396

Summary: LayoutTest media/modern-media-controls/media-controller/media-controller-auto-hide-rewind-with-mouse-enter.html is a flaky failure
Product: WebKit Reporter: Ryan Haddad <ryanhaddad>
Component: New BugsAssignee: Antoine Quint <graouts>
Severity: Normal CC: commit-queue, graouts, jonlee, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Description Flags
Patch none

Description Ryan Haddad 2017-01-24 16:36:46 PST
LayoutTest media/modern-media-controls/media-controller/media-controller-auto-hide-rewind-with-mouse-enter.html is a flaky failure



--- /Volumes/Data/slave/elcapitan-release-tests-wk2/build/layout-test-results/media/modern-media-controls/media-controller/media-controller-auto-hide-rewind-with-mouse-enter-expected.txt
+++ /Volumes/Data/slave/elcapitan-release-tests-wk2/build/layout-test-results/media/modern-media-controls/media-controller/media-controller-auto-hide-rewind-with-mouse-enter-actual.txt
@@ -7,7 +7,7 @@
 PASS controlsBar.classList.contains('faded') is false
 Auto-hide timer has elapsed, controls bar should be faded.
-PASS controlsBar.classList.contains('faded') is true
+FAIL controlsBar.classList.contains('faded') should be true. Was false.
 Mouse moved over the media, controls bar should be visible.
 PASS controlsBar.classList.contains('faded') is false
Comment 1 Ryan Haddad 2017-01-24 16:37:35 PST
When I looked at this test yesterday, it had not failed since the 20th. It has failed 4 times since yesterday night.
Comment 2 Antoine Quint 2017-01-25 05:38:32 PST
This is tricky because this test, and a host of others, is timing-sensitive by design since it's testing the auto-hide timer. The test checks as close as possible to the auto-hide delay that the controls are still visible, and then again as soon as possible after the auto-hide delay has elapsed to check that the controls are no longer visible. So in certain cases, probably where the system is under pressure and timers run late, we get in cases where the check prior to the timer firing fails because we've actually run past auto-hide delay. We're going to have to find a different way to test this.
Comment 3 Jon Lee 2017-01-25 10:10:38 PST
When testing could we set the auto-hide timer to 0?
Comment 4 Ryan Haddad 2017-01-25 12:06:55 PST
Marked test as flaky in http://trac.webkit.org/projects/webkit/changeset/211157
Comment 5 Radar WebKit Bug Importer 2017-03-02 18:00:25 PST
Comment 6 Antoine Quint 2017-03-02 18:15:08 PST
Created attachment 303281 [details]
Comment 7 WebKit Commit Bot 2017-03-02 19:27:27 PST
Comment on attachment 303281 [details]

Clearing flags on attachment: 303281

Committed r213342: <http://trac.webkit.org/changeset/213342>
Comment 8 WebKit Commit Bot 2017-03-02 19:27:32 PST
All reviewed patches have been landed.  Closing bug.