Summary: | LoadWebLocalizedStrings method should be moved in correct file | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Aakash Jain <aakash_jain> | ||||||||||
Component: | WebKit Misc. | Assignee: | Aakash Jain <aakash_jain> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | aakash_jain, ap, commit-queue | ||||||||||
Priority: | P2 | ||||||||||||
Version: | WebKit Nightly Build | ||||||||||||
Hardware: | iPhone / iPad | ||||||||||||
OS: | Unspecified | ||||||||||||
Attachments: |
|
Description
Aakash Jain
2017-01-24 15:51:36 PST
Created attachment 299660 [details]
Proposed patch
Attachment 299660 [details] did not pass style-queue:
ERROR: Source/WebKit/ios/Misc/WebUIKitSupport.mm:57: No space between ^ and block definition. [whitespace/brackets] [4]
Total errors found: 1 in 3 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 299664 [details]
Updated patch
Comment on attachment 299664 [details] Updated patch View in context: https://bugs.webkit.org/attachment.cgi?id=299664&action=review > Source/WebKit/ios/Misc/WebUIKitSupport.mm:48 > +void LoadWebLocalizedStrings(void); Can this function be a static one too? If made static, it won't need a declaration. > Source/WebKit/ios/Misc/WebUIKitSupport.mm:66 > +void LoadWebLocalizedStrings(void) As this is a C++ file (not plain C), "(void)" is not needed, "()" is the right way to write it. Created attachment 299715 [details]
Updated patch
Made LoadWebLocalizedStrings static, and removed void.
Comment on attachment 299715 [details] Updated patch Rejecting attachment 299715 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 299715, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in Source/WebKit/ios/ChangeLog contains OOPS!. Full output: http://webkit-queues.webkit.org/results/2947779 Created attachment 299716 [details]
Updated patch
Added reviewer name in ChangeLog.
Comment on attachment 299716 [details] Updated patch Clearing flags on attachment: 299716 Committed r211156: <http://trac.webkit.org/changeset/211156> All reviewed patches have been landed. Closing bug. |