Bug 167381

Summary: Work around a crash when running media/modern-media-controls/pip-support/pip-support-enabled.html
Product: WebKit Reporter: Antoine Quint <graouts>
Component: MediaAssignee: Antoine Quint <graouts>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: Safari Technology Preview   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=164336
Attachments:
Description Flags
Patch none

Description Antoine Quint 2017-01-24 13:49:29 PST
As found while diagnosing https://bugs.webkit.org/show_bug.cgi?id=164336, we hit the assertion in WebCore/platform/mac/WebVideoFullscreenHUDWindowController.mm timeToString() when running the tests media/modern-media-controls/pip-support/pip-support-click.html and media/modern-media-controls/pip-support/pip-support-enabled.html in succession. Exiting PiP in the first test before moving on to the next one works around the issue.
Comment 1 Antoine Quint 2017-01-24 13:52:03 PST
Created attachment 299627 [details]
Patch
Comment 2 WebKit Commit Bot 2017-01-24 18:57:58 PST
Comment on attachment 299627 [details]
Patch

Clearing flags on attachment: 299627

Committed r211130: <http://trac.webkit.org/changeset/211130>
Comment 3 WebKit Commit Bot 2017-01-24 18:58:01 PST
All reviewed patches have been landed.  Closing bug.