Bug 167381

Summary:

Work around a crash when running media/modern-media-controls/pip-support/pip-support-enabled.html

Product:

WebKit

Reporter:

Antoine Quint <graouts>

Component:

Media

Assignee:

Antoine Quint <graouts>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue

Priority:

Version:

Safari Technology Preview

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=164336

Attachments:

Description	Flags
Patch	none

Antoine Quint

Reported 2017-01-24 13:49:29 PST

As found while diagnosing https://bugs.webkit.org/show_bug.cgi?id=164336, we hit the assertion in WebCore/platform/mac/WebVideoFullscreenHUDWindowController.mm timeToString() when running the tests media/modern-media-controls/pip-support/pip-support-click.html and media/modern-media-controls/pip-support/pip-support-enabled.html in succession. Exiting PiP in the first test before moving on to the next one works around the issue.

Attachments
Patch (3.27 KB, patch) 2017-01-24 13:52 PST, Antoine Quint	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Antoine Quint

Comment 1 2017-01-24 13:52:03 PST

Created attachment 299627 [details] Patch

WebKit Commit Bot

Comment 2 2017-01-24 18:57:58 PST

Comment on attachment 299627 [details] Patch Clearing flags on attachment: 299627 Committed r211130: <http://trac.webkit.org/changeset/211130>

WebKit Commit Bot

Comment 3 2017-01-24 18:58:01 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.