Bug 167367

Summary: [GTK] Do not paint non composited content into the window when using the threaded compositor
Product: WebKit Reporter: Miguel Gomez <magomez>
Component: WebKitGTKAssignee: Miguel Gomez <magomez>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, commit-queue, esprehn+autocc, glenn, kondapallykalyan, mcatanzaro, simon.fraser
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Miguel Gomez
Reported 2017-01-24 01:59:27 PST
When using the threaded compositor we need to send the non composited content for compositing as well, not painting it directly into the window.
Attachments
Patch (1.53 KB, patch)
2017-01-24 02:05 PST, Miguel Gomez 		no flags
DetailsFormatted DiffDiff
Patch (1.49 KB, patch)
2017-01-24 03:43 PST, Miguel Gomez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Miguel Gomez
Comment 1 2017-01-24 02:05:53 PST
Created attachment 299590 [details] Patch
Carlos Garcia Campos
Comment 2 2017-01-24 02:48:33 PST
Comment on attachment 299590 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=299590&action=review > Source/WebCore/rendering/RenderLayerBacking.cpp:2223 > +#if USE(COORDINATED_GRAPHICS_THREADED) > + return false; > +#endif The function already returns false when !m_owningLayer.isRootLayer(), I think we can move this #ifdef outside the if, and make it an early return of the function like if (m_usingTiledCacheLayer)
Miguel Gomez
Comment 3 2017-01-24 03:43:13 PST
Created attachment 299594 [details] Patch
WebKit Commit Bot
Comment 4 2017-01-24 04:36:33 PST
The commit-queue encountered the following flaky tests while processing attachment 299594 [details]: The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 5 2017-01-24 08:26:48 PST
Comment on attachment 299594 [details] Patch Clearing flags on attachment: 299594 Committed r211084: <http://trac.webkit.org/changeset/211084>
WebKit Commit Bot
Comment 6 2017-01-24 08:26:52 PST
All reviewed patches have been landed. Closing bug.
Michael Catanzaro
Comment 7 2017-01-24 08:39:20 PST
The indentation is wrong; too many spaces before the return. Also, the rest of the code should not be compiled at all; isn't it going to give unreachable code warnings?
Note You need to log in before you can comment on or make changes to this bug.