Bug 167366

Summary: Add invalid value tests to Link header handling.
Product: WebKit Reporter: Yoav Weiss <yoav>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, commit-queue, dino, rniwa, yoav
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Yoav Weiss
Reported 2017-01-24 01:57:45 PST
Add invalid value tests to Link header handling.
Attachments
Patch (4.22 KB, patch)
2017-01-24 01:59 PST, Yoav Weiss 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yoav Weiss
Comment 1 2017-01-24 01:59:18 PST
Created attachment 299589 [details] Patch
Alex Christensen
Comment 2 2017-01-25 00:34:56 PST
Comment on attachment 299589 [details] Patch Cool Let's also add one with "as=script; as=style" in the same header just to verify that we don't accidentally change behavior when there are duplicates.
Yoav Weiss
Comment 3 2017-01-25 00:49:48 PST
(In reply to comment #2) > Comment on attachment 299589 [details] > Patch > > Cool > Let's also add one with "as=script; as=style" in the same header just to > verify that we don't accidentally change behavior when there are duplicates. Adding that test here won't really tell us which attribute is used. In order to make that test meaningful, I want to first land https://bugs.webkit.org/show_bug.cgi?id=159678 and then duplicate the test there for headers.
Yoav Weiss
Comment 4 2017-01-29 06:49:38 PST
Added https://bugs.webkit.org/show_bug.cgi?id=167560 Landing this in the mean time
WebKit Commit Bot
Comment 5 2017-01-29 07:15:06 PST
Comment on attachment 299589 [details] Patch Clearing flags on attachment: 299589 Committed r211352: <http://trac.webkit.org/changeset/211352>
WebKit Commit Bot
Comment 6 2017-01-29 07:15:12 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.