Bug 16734

Summary: Web Inspector: Better represent custom getters in the properties pane
Product: WebKit Reporter: Timothy Hatcher <timothy>
Component: Web Inspector (Deprecated)Assignee: Pavel Feldman <pfeldman>
Status: RESOLVED FIXED    
Severity: Minor CC: ossy, pfeldman, yurys
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 16011    
Bug Blocks:    
Attachments:
Description Flags
Patch yurys: review+

Timothy Hatcher
Reported 2008-01-04 13:00:29 PST
The fix for bug 16011 shows getters as a &mdash;. We should add a new localized string like "getter" or "getter and setter" when we can.
Attachments
Patch (9.87 KB, patch)
2011-07-26 06:02 PDT, Pavel Feldman 		yurys: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Roben (:aroben)
Comment 1 2008-01-29 11:11:59 PST
<rdar://problem/5712908>
Pavel Feldman
Comment 2 2011-07-26 06:02:48 PDT
Created attachment 101992 [details] Patch
Yury Semikhatsky
Comment 3 2011-07-26 07:31:08 PDT
Comment on attachment 101992 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=101992&action=review Please revert unnecessary changes, otherwise looks good. > Source/WebCore/inspector/InjectedScriptSource.js:203 > + property.name = propertyName + ""; Why is this concatenation needed? > Source/WebCore/inspector/InjectedScriptSource.js:-196 > - property.value = this._wrapObject(value, objectGroupName); What was the reason for changing this block? It should work without the change and it was clear that exception could only be thrown in object[propertyName]
Pavel Feldman
Comment 4 2011-07-26 07:44:29 PDT
Committed r91754: <http://trac.webkit.org/changeset/91754>
Csaba Osztrogonác
Comment 5 2011-07-26 08:32:52 PDT
the new test fails on Qt bot: http://build.webkit.org/results/Qt%20Linux%20Release/r91754%20%2835775%29/inspector/runtime/runtime-getProperties-pretty-diff.html Could you check it, please?
Note You need to log in before you can comment on or make changes to this bug.