Bug 167330

Summary: URLParser should fail to parse percent-encoded invalid UTF-8 sequences
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: zcorpan
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch thorton: review+

Alex Christensen
Reported 2017-01-23 15:16:16 PST
URLParser should fail to parse percent-encoded invalid UTF-8 sequences
Attachments
Patch (3.77 KB, patch)
2017-01-23 15:21 PST, Alex Christensen 		thorton: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2017-01-23 15:21:52 PST
Created attachment 299547 [details] Patch
Alex Christensen
Comment 2 2017-01-23 15:28:22 PST
http://trac.webkit.org/r211067
Darin Adler
Comment 3 2017-01-23 18:00:47 PST
Comment on attachment 299547 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=299547&action=review > Source/WebCore/platform/URLParser.cpp:2465 > ALWAYS_INLINE static bool containsOnlyASCII(const String& string) Why does URLParser have its own version of this function? Shouldn’t we put this into WTF? > Source/WebCore/platform/URLParser.cpp:2467 > + ASSERT(!string.isNull()); Why?
Alex Christensen
Comment 4 2017-01-23 18:03:27 PST
Comment on attachment 299547 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=299547&action=review >> Source/WebCore/platform/URLParser.cpp:2465 >> ALWAYS_INLINE static bool containsOnlyASCII(const String& string) > > Why does URLParser have its own version of this function? Shouldn’t we put this into WTF? probably. >> Source/WebCore/platform/URLParser.cpp:2467 >> + ASSERT(!string.isNull()); > > Why? I just made it so that the one caller of this function can't call it with a null String. If we put this in WTF, that won't necessarily be true.
Alexey Proskuryakov
Comment 5 2017-02-02 11:06:54 PST
*** Bug 167730 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.