Bug 16733

Summary: REGRESSION: Crash on Safari Start
Product: WebKit Reporter: Cameo Wood <cameowood>
Component: New BugsAssignee: Alexey Proskuryakov <ap>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, aroben, mrowe
Priority: P1 Keywords: Regression
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows XP   
Attachments:
Description Flags
Dump
none
proposed fix aroben: review+

Cameo Wood
Reported 2008-01-04 12:58:13 PST
Latest nightly, WebKit-SVN-r29152, core dumps on start.
Attachments
Dump (26.02 KB, text/plain)
2008-01-04 12:58 PST, Cameo Wood
no flags
proposed fix (3.29 KB, patch)
2008-01-04 13:45 PST, Alexey Proskuryakov
aroben: review+
Cameo Wood
Comment 1 2008-01-04 12:58:41 PST
808caaa4.8ce9.9cd6c799e9f6
Comment 2 2008-01-04 13:16:11 PST
me too. It's when WebView::tabKeyCyclesThroughElements(int *) with arg (int*)1. With debugger, IWebViewPrivate have unwanted executeCoreCommandByName() now. --- ??_7WebView@@6BIWebViewPrivate@@@ dd offset ?QueryInterface@WebView@@W3AGJABU_GUID@@PAPAX@Z dd offset ?AddRef@WebView@@W3AGKXZ dd offset ?Release@WebView@@W3AGKXZ dd offset ?setInViewSourceMode@WebView@@UAGJH@Z dd offset ?inViewSourceMode@WebView@@UAGJPAH@Z dd offset ?viewWindow@WebView@@UAGJPAI@Z dd offset ?setFormDelegate@WebView@@UAGJPAUIWebFormDelegate@@@Z dd offset ?formDelegate@WebView@@UAGJPAPAUIWebFormDelegate@@@Z dd offset ?setFrameLoadDelegatePrivate@WebView@@UAGJPAUIWebFrameLoadDelegatePrivate@@@Z dd offset ?frameLoadDelegatePrivate@WebView@@UAGJPAPAUIWebFrameLoadDelegatePrivate@@@Z dd offset ?scrollOffset@WebView@@UAGJPAUtagPOINT@@@Z dd offset ?scrollBy@WebView@@UAGJPAUtagPOINT@@@Z dd offset ?visibleContentRect@WebView@@UAGJPAUtagRECT@@@Z dd offset ?updateActiveState@WebView@@UAGJXZ dd offset ?executeCoreCommandByName@WebView@@UAGJPA_W0@Z ; <- what's this ??? dd offset ?markAllMatchesForText@WebView@@UAGJPA_WHHIPAI@Z dd offset ?unmarkAllTextMatches@WebView@@UAGJXZ dd offset ?rectsForTextMatches@WebView@@UAGJPAPAUIEnumTextMatches@@@Z dd offset ?selectionRect@WebView@@UAGJPAUtagRECT@@@Z dd offset ?generateSelectionImage@WebView@@UAGJHPAI@Z dd offset ?canHandleRequest@WebView@@UAGJPAUIWebURLRequest@@PAH@Z dd offset ?clearFocusNode@WebView@@UAGJXZ dd offset ?setTabKeyCyclesThroughElements@WebView@@UAGJH@Z dd offset ?tabKeyCyclesThroughElements@WebView@@UAGJPAH@Z dd offset ?setAllowSiteSpecificHacks@WebView@@UAGJH@Z dd offset ?addAdditionalPluginPath@WebView@@UAGJPA_W@Z dd offset ?loadBackForwardListFromOtherView@WebView@@UAGJPAUIWebView@@@Z dd offset ?setCustomDropTarget@WebView@@UAGJPAUIDropTarget@@@Z dd offset ?removeCustomDropTarget@WebView@@UAGJXZ dd offset ?setInitialFocus@WebView@@UAGJH@Z dd offset ?inspector@WebView@@UAGJPAPAUIWebInspector@@@Z dd offset ?clearUndoRedoOperations@WebView@@UAGJXZ dd offset ?setProhibitsMainFrameScrolling@WebView@@UAGJH@Z dd offset ?setShouldApplyMacFontAscentHack@WebView@@UAGJH@Z dd offset ?shouldClose@WebView@@UAGJPAH@Z db 0 db 0 db 0 db 0 --- I dont't have devenv for private hardware trouble, so cannot guess what's going wrong.
Alexey Proskuryakov
Comment 3 2008-01-04 13:45:56 PST
Created attachment 18275 [details] proposed fix Also adds back BackwardDelete for shipping Windows Safari pleasure.
Adam Roben (:aroben)
Comment 4 2008-01-04 14:00:30 PST
Comment on attachment 18275 [details] proposed fix r=me, though I don't think we know for sure what the version number will be of the first version of Safari that doesn't use BackwardDelete, so you may just want to remove the parenthetical.
Alexey Proskuryakov
Comment 5 2008-01-04 14:36:24 PST
Committed revision 29178. (In reply to comment #4) > (From update of attachment 18275 [details] [edit]) > r=me, though I don't think we know for sure what the version number will be of > the first version of Safari that doesn't use BackwardDelete, so you may just > want to remove the parenthetical. OK.
808caaa4.8ce9.9cd6c799e9f6
Comment 6 2008-01-04 19:03:11 PST
oops, I've carelessly checked OLDER IWebViewPrivate.idl on trac. sorry for ugly post, and thanks for quickly fixation.
Note You need to log in before you can comment on or make changes to this bug.