Summary: | REGRESSION: Crash on Safari Start | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Cameo Wood <cameowood> | ||||||
Component: | New Bugs | Assignee: | Alexey Proskuryakov <ap> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | ap, aroben, mrowe | ||||||
Priority: | P1 | Keywords: | Regression | ||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | PC | ||||||||
OS: | Windows XP | ||||||||
Attachments: |
|
Description
Cameo Wood
2008-01-04 12:58:13 PST
Created attachment 18273 [details]
Dump
me too. It's when WebView::tabKeyCyclesThroughElements(int *) with arg (int*)1. With debugger, IWebViewPrivate have unwanted executeCoreCommandByName() now. --- ??_7WebView@@6BIWebViewPrivate@@@ dd offset ?QueryInterface@WebView@@W3AGJABU_GUID@@PAPAX@Z dd offset ?AddRef@WebView@@W3AGKXZ dd offset ?Release@WebView@@W3AGKXZ dd offset ?setInViewSourceMode@WebView@@UAGJH@Z dd offset ?inViewSourceMode@WebView@@UAGJPAH@Z dd offset ?viewWindow@WebView@@UAGJPAI@Z dd offset ?setFormDelegate@WebView@@UAGJPAUIWebFormDelegate@@@Z dd offset ?formDelegate@WebView@@UAGJPAPAUIWebFormDelegate@@@Z dd offset ?setFrameLoadDelegatePrivate@WebView@@UAGJPAUIWebFrameLoadDelegatePrivate@@@Z dd offset ?frameLoadDelegatePrivate@WebView@@UAGJPAPAUIWebFrameLoadDelegatePrivate@@@Z dd offset ?scrollOffset@WebView@@UAGJPAUtagPOINT@@@Z dd offset ?scrollBy@WebView@@UAGJPAUtagPOINT@@@Z dd offset ?visibleContentRect@WebView@@UAGJPAUtagRECT@@@Z dd offset ?updateActiveState@WebView@@UAGJXZ dd offset ?executeCoreCommandByName@WebView@@UAGJPA_W0@Z ; <- what's this ??? dd offset ?markAllMatchesForText@WebView@@UAGJPA_WHHIPAI@Z dd offset ?unmarkAllTextMatches@WebView@@UAGJXZ dd offset ?rectsForTextMatches@WebView@@UAGJPAPAUIEnumTextMatches@@@Z dd offset ?selectionRect@WebView@@UAGJPAUtagRECT@@@Z dd offset ?generateSelectionImage@WebView@@UAGJHPAI@Z dd offset ?canHandleRequest@WebView@@UAGJPAUIWebURLRequest@@PAH@Z dd offset ?clearFocusNode@WebView@@UAGJXZ dd offset ?setTabKeyCyclesThroughElements@WebView@@UAGJH@Z dd offset ?tabKeyCyclesThroughElements@WebView@@UAGJPAH@Z dd offset ?setAllowSiteSpecificHacks@WebView@@UAGJH@Z dd offset ?addAdditionalPluginPath@WebView@@UAGJPA_W@Z dd offset ?loadBackForwardListFromOtherView@WebView@@UAGJPAUIWebView@@@Z dd offset ?setCustomDropTarget@WebView@@UAGJPAUIDropTarget@@@Z dd offset ?removeCustomDropTarget@WebView@@UAGJXZ dd offset ?setInitialFocus@WebView@@UAGJH@Z dd offset ?inspector@WebView@@UAGJPAPAUIWebInspector@@@Z dd offset ?clearUndoRedoOperations@WebView@@UAGJXZ dd offset ?setProhibitsMainFrameScrolling@WebView@@UAGJH@Z dd offset ?setShouldApplyMacFontAscentHack@WebView@@UAGJH@Z dd offset ?shouldClose@WebView@@UAGJPAH@Z db 0 db 0 db 0 db 0 --- I dont't have devenv for private hardware trouble, so cannot guess what's going wrong. Created attachment 18275 [details]
proposed fix
Also adds back BackwardDelete for shipping Windows Safari pleasure.
Comment on attachment 18275 [details]
proposed fix
r=me, though I don't think we know for sure what the version number will be of the first version of Safari that doesn't use BackwardDelete, so you may just want to remove the parenthetical.
Committed revision 29178. (In reply to comment #4) > (From update of attachment 18275 [details] [edit]) > r=me, though I don't think we know for sure what the version number will be of > the first version of Safari that doesn't use BackwardDelete, so you may just > want to remove the parenthetical. OK. oops, I've carelessly checked OLDER IWebViewPrivate.idl on trac. sorry for ugly post, and thanks for quickly fixation. |