Summary: | Maintain ordering when doing speculative loads | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Antti Koivisto <koivisto> | ||||
Component: | Page Loading | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | beidson, cdumez, cgarcia, commit-queue, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Antti Koivisto
2017-01-23 14:26:30 PST
Created attachment 299539 [details]
patch
Comment on attachment 299539 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=299539&action=review r=me > Source/WebKit2/NetworkProcess/cache/NetworkCacheSubresourcesEntry.cpp:109 > + Vector<SubresourceInfo> result; I think we should reserveInitialCapacity() and uncheckedAppend() since we know there will be at most subresourceLoads.size() items and the common case will be subresourceLoads.size() items. > Source/WebKit2/NetworkProcess/cache/NetworkCacheSubresourcesEntry.h:49 > + , m_requestHeaders(request.httpHeaderFields()) It is a bit unfortunate that we are now copying those HashMaps for transient resources too now. I hope this does not show on PLT. Comment on attachment 299539 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=299539&action=review >> Source/WebKit2/NetworkProcess/cache/NetworkCacheSubresourcesEntry.cpp:109 >> + Vector<SubresourceInfo> result; > > I think we should reserveInitialCapacity() and uncheckedAppend() since we know there will be at most subresourceLoads.size() items and the common case will be subresourceLoads.size() items. The patch landed with a call to reserveCapacity/append, but reserveInitialCapacity/uncheckedAppend are more efficient. Oops! Did that in https://trac.webkit.org/r211076 |