Bug 167313

Summary: gtest fails to link on Linux due to missing -lpthread
Product: WebKit Reporter: Timothy Hatcher <timothy>
Component: Tools / TestsAssignee: Timothy Hatcher <timothy>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, cdumez, commit-queue, lforschler, mcatanzaro
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Other   
OS: Linux   
Attachments:
Description Flags
Patch
achristensen: review+, achristensen: commit-queue+
Patch none

Timothy Hatcher
Reported 2017-01-23 09:38:54 PST
Building gtest is failing for me because CMAKE_USE_PTHREADS_INIT is not defined and GTEST_HAS_PTHREAD will be assumed true if it is undefined.
Attachments
Patch (1.37 KB, patch)
2017-01-23 09:58 PST, Timothy Hatcher 		achristensen: review+
achristensen: commit-queue+
DetailsFormatted DiffDiff
Patch (1.37 KB, patch)
2017-01-23 10:10 PST, Timothy Hatcher 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Timothy Hatcher
Comment 1 2017-01-23 09:58:02 PST
Created attachment 299521 [details] Patch
WebKit Commit Bot
Comment 2 2017-01-23 10:00:42 PST
Attachment 299521 [details] did not pass style-queue: ERROR: Source/ThirdParty/gtest/CMakeLists.txt:53: One space between command "else" and its parentheses, should be "else (" [whitespace/parentheses] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Timothy Hatcher
Comment 3 2017-01-23 10:10:36 PST
Created attachment 299522 [details] Patch
WebKit Commit Bot
Comment 4 2017-01-23 10:47:07 PST
Comment on attachment 299522 [details] Patch Clearing flags on attachment: 299522 Committed r211044: <http://trac.webkit.org/changeset/211044>
WebKit Commit Bot
Comment 5 2017-01-23 10:47:13 PST
All reviewed patches have been landed. Closing bug.
Timothy Hatcher
Comment 6 2017-01-23 12:27:39 PST
Comment on attachment 299522 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=299522&action=review > Source/ThirdParty/gtest/CMakeLists.txt:48 > +find_package(Threads) Turns out this isn't needed, it is assumed to happen in the platform make options file. I'll remove this.
Timothy Hatcher
Comment 7 2017-01-23 13:39:28 PST
Follow up. https://trac.webkit.org/changeset/211050
Note You need to log in before you can comment on or make changes to this bug.