Bug 167298

Summary: Add pdr to the rendering watchlist
Product: WebKit Reporter: Philip Rogers <pdr>
Component: Tools / TestsAssignee: Philip Rogers <pdr>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, glenn, lforschler, rego
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Add pdr to the rendering watchlist kling: review+

Philip Rogers
Reported 2017-01-22 20:57:21 PST
I'd like to do a better job at keeping blink and webkit compatible in both directions.
Attachments
Add pdr to the rendering watchlist (2.78 KB, patch)
2017-01-22 21:04 PST, Philip Rogers 		kling: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Philip Rogers
Comment 1 2017-01-22 21:04:42 PST
Created attachment 299497 [details] Add pdr to the rendering watchlist
WebKit Commit Bot
Comment 2 2017-01-22 21:07:18 PST
Attachment 299497 [details] did not pass style-queue: ERROR: Tools/Scripts/webkitpy/common/config/contributors.json:0: contributors.json should not be modified through the commit queue [json/syntax] [5] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Philip Rogers
Comment 3 2017-01-23 21:32:32 PST
Thanks Andreas. I no longer have the svn cred to land this without the commit queue (per the security clause in https://webkit.org/commit-and-review-policy/#inactive-committer-or-reviewer-status). Would you be willing to webkit-patch land this on my behalf?
Manuel Rego Casasnovas
Comment 4 2017-03-07 05:16:31 PST
Committed r213512: <http://trac.webkit.org/changeset/213512>
Manuel Rego Casasnovas
Comment 5 2017-03-07 05:17:19 PST
@pdr I've landed this for you. PS: I found this just by chance, looking for issues related to the watchlist as it seems to be failing for me in some cases. :-)
Philip Rogers
Comment 6 2017-03-07 09:39:58 PST
Thank you!
Note You need to log in before you can comment on or make changes to this bug.