Bug 167268

Summary: When Safari reloads pages with Flash objects after Flash is installed, placeholders don't paint (but do work!)
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal CC: rmondello, sam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch sam: review+

Anders Carlsson
Reported 2017-01-20 16:50:05 PST
When Safari reloads pages with Flash objects after Flash is installed, placeholders don't paint (but do work!)
Attachments
Patch (7.26 KB, patch)
2017-01-20 16:52 PST, Anders Carlsson 		no flags
DetailsFormatted DiffDiff
Patch (7.19 KB, patch)
2017-01-23 10:46 PST, Anders Carlsson 		no flags
DetailsFormatted DiffDiff
Patch (7.18 KB, patch)
2017-01-23 11:43 PST, Anders Carlsson 		sam: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2017-01-20 16:52:46 PST
Created attachment 299404 [details] Patch
Ricky Mondello
Comment 2 2017-01-20 17:30:28 PST
<rdar://problem/29857388>
Anders Carlsson
Comment 3 2017-01-23 10:46:12 PST
Created attachment 299525 [details] Patch
Anders Carlsson
Comment 4 2017-01-23 11:43:08 PST
Created attachment 299529 [details] Patch
Sam Weinig
Comment 5 2017-01-23 12:53:37 PST
Comment on attachment 299529 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=299529&action=review > Source/WebCore/page/Page.cpp:540 > Vector<Ref<Frame>> framesNeedingReload; Can you remove this? It seems unused now. > Source/WebCore/page/Page.cpp:546 > + pluginInfoProvider->refresh(reload); Is there anything ensuring the PluginInfoProviders are kept alive for this loop? If they are tied to the page's lifetime, do we really need the two loops? > Source/WebCore/plugins/PluginInfoProvider.cpp:57 > + for (auto& frame : framesNeedingReload) > + frame->loader().reload(); For a specific page, is there any reason to reload a frame that is a child of a frame that has already been reloaded in this loop? For instance, if the main frame is reloaded, what is the value of reloading any subframes?
Sam Weinig
Comment 6 2017-01-23 12:54:54 PST
Oh, as always, is this testable?
Anders Carlsson
Comment 7 2017-01-23 12:59:52 PST
Committed r211052: <http://trac.webkit.org/changeset/211052>
Darin Adler
Comment 8 2017-01-23 17:57:38 PST
Comment on attachment 299529 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=299529&action=review >> Source/WebCore/page/Page.cpp:540 >> Vector<Ref<Frame>> framesNeedingReload; > > Can you remove this? It seems unused now. Patch landed with this unused vector still there. Should remove it!
Note You need to log in before you can comment on or make changes to this bug.