Simplify InjectedBundle::overrideBoolPreferenceForTestRunner

• Component: Tools / Tests
• Status: NEW ---

[Joseph Pecoraro]

Simplify InjectedBundle::overrideBoolPreferenceForTestRunner

This path of toggling preferences should only be used for WebKit2 level settings.

- When setting a WebCore::Setting tests can just use internals.settings.setFoo()
- When setting a RuntimeEnabledFeature no good approach exists yet, but this is not ideal.

In any case the majority of these are not being used currently, so we should stop the pattern of adding code here that isn't getting used.

[Joseph Pecoraro]

Created attachment 299317 [details]
[PATCH] Proposed Fix

[Joseph Pecoraro]

Created attachment 299320 [details]
[PATCH] Proposed Fix

[Joseph Pecoraro]

Comment on attachment 299320 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=299320&action=review

> Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp:-166
> -#if ENABLE(SERVICE_CONTROLS)

Need to add this back around this particular control I guess. Won't know why my local builds didn't see this...

[Build Bot]

Comment on attachment 299320 [details]
[PATCH] Proposed Fix

Attachment 299320 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2918778

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 299323 [details]
Archive of layout-test-results from ews107 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[Joseph Pecoraro]

Once bug 167115 lands (in commit-queue) then we can remove more, so holding off on this until later today.

[Joseph Pecoraro]

Created attachment 299425 [details]
[PATCH] Proposed Fix

[Build Bot]

Comment on attachment 299425 [details]
[PATCH] Proposed Fix

Attachment 299425 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2924140

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 299426 [details]
Archive of layout-test-results from ews107 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 299425 [details]
[PATCH] Proposed Fix

Attachment 299425 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2924145

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 299427 [details]
Archive of layout-test-results from ews124 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6

[Joseph Pecoraro]

Comment on attachment 299425 [details]
[PATCH] Proposed Fix

Whoa, the TestRunner APIs end up re-using this path... Might need to keep some of these.