Bug 167221

Summary: iterable<> should be enabled on WK1
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: DOMAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, mmaxfield, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Chris Dumez
Reported 2017-01-19 16:51:49 PST
It is currently enabled by default on WK2 and in WK1 DumpRenderTree. However, it is not enabled by default on WK1. There is no reason to not enable it everywhere at this point.
Attachments
Patch (25.91 KB, patch)
2017-01-19 17:05 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (22.61 KB, patch)
2017-01-19 18:07 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (22.68 KB, patch)
2017-01-19 18:08 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2017-01-19 16:52:55 PST
<rdar://problem/30108531>
Chris Dumez
Comment 2 2017-01-19 16:58:53 PST
This means `for ... of` and forEach() do not work on iterable types such as NodeList.
Chris Dumez
Comment 3 2017-01-19 17:05:11 PST
Created attachment 299288 [details] Patch
youenn fablet
Comment 4 2017-01-19 17:54:27 PST
Comment on attachment 299288 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=299288&action=review > Source/WebCore/bindings/scripts/test/TestNode.idl:-28 > - [EnabledAtRuntime=DOMIterator] iterable<TestNode>; Are there cases where we will like to make utterable enabledatruntime with another flag? If so, it is best to keep TestNode.idl as is. Otherwise, we might want to update the binding generator, addIterablePrototypeProperties in particular.
Chris Dumez
Comment 5 2017-01-19 18:07:07 PST
Created attachment 299295 [details] Patch
Chris Dumez
Comment 6 2017-01-19 18:08:04 PST
Created attachment 299297 [details] Patch
youenn fablet
Comment 7 2017-01-19 18:14:33 PST
Comment on attachment 299297 [details] Patch I'll cq once EWS bots will be happy about it
WebKit Commit Bot
Comment 8 2017-01-19 19:25:03 PST
Comment on attachment 299297 [details] Patch Clearing flags on attachment: 299297 Committed r210949: <http://trac.webkit.org/changeset/210949>
WebKit Commit Bot
Comment 9 2017-01-19 19:25:10 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.