Bug 167221

Summary: iterable<> should be enabled on WK1
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: DOMAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, mmaxfield, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Chris Dumez 2017-01-19 16:51:49 PST 
It is currently enabled by default on WK2 and in WK1 DumpRenderTree. However, it is not enabled by default on WK1. There is no reason to not enable it everywhere at this point.
Comment 1 Radar WebKit Bug Importer 2017-01-19 16:52:55 PST 
<rdar://problem/30108531>
Comment 2 Chris Dumez 2017-01-19 16:58:53 PST 
This means `for ... of` and forEach() do not work on iterable types such as NodeList.
Comment 3 Chris Dumez 2017-01-19 17:05:11 PST 
Created attachment 299288 [details]
Patch
Comment 4 youenn fablet 2017-01-19 17:54:27 PST 
Comment on attachment 299288 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=299288&action=review

> Source/WebCore/bindings/scripts/test/TestNode.idl:-28
> -    [EnabledAtRuntime=DOMIterator] iterable<TestNode>;

Are there cases where we will like to make utterable enabledatruntime with another flag?
If so, it is best to keep TestNode.idl as is.
Otherwise, we might want to update the binding generator, addIterablePrototypeProperties in particular.
Comment 5 Chris Dumez 2017-01-19 18:07:07 PST 
Created attachment 299295 [details]
Patch
Comment 6 Chris Dumez 2017-01-19 18:08:04 PST 
Created attachment 299297 [details]
Patch
Comment 7 youenn fablet 2017-01-19 18:14:33 PST 
Comment on attachment 299297 [details]
Patch

I'll cq once EWS bots will be happy about it
Comment 8 WebKit Commit Bot 2017-01-19 19:25:03 PST 
Comment on attachment 299297 [details]
Patch

Clearing flags on attachment: 299297

Committed r210949: <http://trac.webkit.org/changeset/210949>
Comment 9 WebKit Commit Bot 2017-01-19 19:25:10 PST 
All reviewed patches have been landed.  Closing bug.