Summary: | JSSegmentedVariableObject and its subclasses should have a sane destruction story | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Filip Pizlo <fpizlo> | ||||||
Component: | JavaScriptCore | Assignee: | Filip Pizlo <fpizlo> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue | ||||||
Priority: | P2 | ||||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Filip Pizlo
2017-01-18 20:21:42 PST
Created attachment 299227 [details]
the patch
Attachment 299227 [details] did not pass style-queue:
ERROR: Source/JavaScriptCore/runtime/JSSegmentedVariableObject.h:104: The parameter name "vm" adds no information, so it should be removed. [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/runtime/JSSegmentedVariableObjectSubspace.cpp:29: Alphabetical sorting problem. [build/include_order] [4]
Total errors found: 2 in 16 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 299230 [details]
the patch
Landed in https://trac.webkit.org/changeset/210912 |