Bug 167181
| Summary: | check-webkit-style applies style checks to multi-line comments in Python | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Jonathan Bedard <jbedard> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED LATER | ||
| Severity: | Normal | CC: | lforschler |
| Priority: | P5 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Jonathan Bedard
Check-webkit-style applies style checks to multi-line string in Python. This is incorrect, coding style checks should not be applied to multi-line strings.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Jonathan Bedard
Given that this error is actually in pylint, I don't think it will be worth engineering time to fix. We could build a parser before passing data into pylint to remove multi-line strings, but given that multi-line strings are pretty rare in our code (mostly in tests) and that we only output pylint errors when code is changed, I don't think the impact of this bug warrants a fix.