Bug 167137

Summary:

[Streams API] ReadableStream generic reader constructor does not need to call ReadableStream getReader

Product:

WebKit

Reporter:

youenn fablet <youennf>

Component:

WebCore Misc.

Assignee:

youenn fablet <youennf>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin, calvaris, commit-queue

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Fixing compilation	none
Patch for landing	none

youenn fablet

Reported 2017-01-17 14:43:46 PST

The spec changed and we should the private constructor instead.

Attachments
Patch (4.92 KB, patch) 2017-01-17 14:45 PST, youenn fablet	no flags	Details Formatted Diff Diff
Patch (5.04 KB, patch) 2017-01-17 14:53 PST, youenn fablet	no flags	Details Formatted Diff Diff
Fixing compilation (5.13 KB, patch) 2017-01-17 15:20 PST, youenn fablet	no flags	Details Formatted Diff Diff
Patch for landing (5.06 KB, patch) 2017-01-18 11:31 PST, youenn fablet	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

youenn fablet

Comment 1 2017-01-17 14:45:58 PST

Created attachment 299063 [details] Patch

youenn fablet

Comment 2 2017-01-17 14:53:23 PST

Created attachment 299065 [details] Patch

youenn fablet

Comment 3 2017-01-17 15:20:59 PST

Created attachment 299071 [details] Fixing compilation

Xabier Rodríguez Calvar

Comment 4 2017-01-18 01:15:34 PST

Comment on attachment 299071 [details] Fixing compilation View in context: https://bugs.webkit.org/attachment.cgi?id=299071&action=review > LayoutTests/streams/shadowing-getReader.html:13 > +stream = new ReadableStream(); Do you need to create the stream twice?

youenn fablet

Comment 5 2017-01-18 11:31:00 PST

Created attachment 299161 [details] Patch for landing

youenn fablet

Comment 6 2017-01-18 11:32:10 PST

Thanks for the review. (In reply to comment #4) > Comment on attachment 299071 [details] > Fixing compilation > > View in context: > https://bugs.webkit.org/attachment.cgi?id=299071&action=review > > > LayoutTests/streams/shadowing-getReader.html:13 > > +stream = new ReadableStream(); > > Do you need to create the stream twice? We need the first one to get reader constructor and the second one to do the actual test. I rewrote a bit the test to make it clearer.

WebKit Commit Bot

Comment 7 2017-01-18 12:07:57 PST

Comment on attachment 299161 [details] Patch for landing Clearing flags on attachment: 299161 Committed r210862: <http://trac.webkit.org/changeset/210862>

WebKit Commit Bot

Comment 8 2017-01-18 12:08:01 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.