Summary: | Persist derived data | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Antti Koivisto <koivisto> | ||||||||
Component: | Page Loading | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | beidson, buildbot, cdumez, cgarcia, commit-queue, dbates, japhet, rniwa | ||||||||
Priority: | P2 | ||||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Antti Koivisto
2017-01-17 13:30:22 PST
Created attachment 299060 [details]
patch
Attachment 299060 [details] did not pass style-queue:
ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCache.h:124: Extra space before ( in function call [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCache.cpp:618: Extra space before ( in function call [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/NetworkResourceLoader.cpp:575: 'loader' is incorrectly named. It should be named 'protectedThis'. [readability/naming/protected] [4]
Total errors found: 3 in 35 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 299060 [details] patch Attachment 299060 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/2905920 New failing tests: imported/w3c/web-platform-tests/html/browsers/history/the-location-interface/location-protocol-setter-non-broken.html Created attachment 299075 [details]
Archive of layout-test-results from ews101 for mac-elcapitan
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Comment on attachment 299060 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=299060&action=review > Source/WebKit2/NetworkProcess/NetworkResourceLoader.cpp:576 > + NetworkCache::DataKey key { originalRequest().cachePartition(), type, *entry->sourceStorageRecord().bodyHash }; Can't use cachePartition here because it doesn't exist when ENABLE(CACHE_PARTITIONING) is false, as on GTK and EFL. (Why is it off on these ports?) Comment on attachment 299060 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=299060&action=review > Source/WebKit2/NetworkProcess/NetworkResourceLoader.cpp:575 > + RefPtr<NetworkResourceLoader> loader(this); You could capture this with makeRef(*this) instead. > Source/WebKit2/NetworkProcess/cache/NetworkCache.cpp:354 > - m_storage->retrieve(storageKey, priority, [this, request, completionHandler = WTFMove(completionHandler), startTime, storageKey, frameID](std::unique_ptr<Storage::Record> record) { > + m_storage->retrieve(storageKey, priority, [this, request, completionHandler = WTFMove(completionHandler), startTime, storageKey, frameID](auto record) { This seems a little unrelated, but sure. > Source/WebKit2/NetworkProcess/cache/NetworkCache.cpp:634 > +{ This function should return if the cache is not enabled. Created attachment 299078 [details]
patch
Attachment 299078 [details] did not pass style-queue:
ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCache.h:124: Extra space before ( in function call [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCache.cpp:618: Extra space before ( in function call [whitespace/parens] [4]
Total errors found: 2 in 35 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 299078 [details] patch Clearing flags on attachment: 299078 Committed r210835: <http://trac.webkit.org/changeset/210835> All reviewed patches have been landed. Closing bug. |