Bug 167075 – Web Inspector: split console should be allowed for Network and Timeline tabs when Inspector is not docked

• Component: Web Inspector
• Status: RESOLVED FIXED

[Blaze Burg]

The only problematic case is when docked to bottom, we have basically no room at all. I am pretty sure that this is a getter or method call, so this can be done dynamically. (In that case I don't think we should ever show split console while docked to bottom).

[Radar WebKit Bug Importer]

<rdar://problem/30033611>

[Devin Rousso]

Created attachment 298937 [details]
Patch

[Timothy Hatcher]

Comment on attachment 298937 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=298937&action=review

> Source/WebInspectorUI/UserInterface/Views/ContentView.js:313
> -        return true;
> +        return WebInspector.dockedConfigurationSupportsSplitContentBrowser();

Maybe if this is the default then the subclass methods that do the same thing can just be removed.

> Source/WebInspectorUI/UserInterface/Views/NetworkTabContentView.js:64
> -        return false;
> +        return WebInspector.dockedConfigurationSupportsSplitContentBrowser();

This still poses a problem. Since Network has real sidebar, if the split console is shown, the sidebar will show things that don't line up with the DataGrid in the content view. A comment to that effect should be added to explain this. Give it a try with a lot of network requests and you will see what I mean.

> Source/WebInspectorUI/UserInterface/Views/TimelineTabContentView.js:314
> -        return false;
> +        return WebInspector.dockedConfigurationSupportsSplitContentBrowser();

Timeline use to be the same way, but we don't have a real sidebar anymore so it should be fine.

[Devin Rousso]

Comment on attachment 298937 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=298937&action=review

>> Source/WebInspectorUI/UserInterface/Views/ContentView.js:313
>> +        return WebInspector.dockedConfigurationSupportsSplitContentBrowser();
> 
> Maybe if this is the default then the subclass methods that do the same thing can just be removed.

Yup.  100% correct.  No idea why I didn't do that...

>> Source/WebInspectorUI/UserInterface/Views/NetworkTabContentView.js:64
>> +        return WebInspector.dockedConfigurationSupportsSplitContentBrowser();
> 
> This still poses a problem. Since Network has real sidebar, if the split console is shown, the sidebar will show things that don't line up with the DataGrid in the content view. A comment to that effect should be added to explain this. Give it a try with a lot of network requests and you will see what I mean.

Oh snap that's a really good point.  I'll revert this.

[Devin Rousso]

Created attachment 299016 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 299016 [details]
Patch

Clearing flags on attachment: 299016

Committed r210911: <http://trac.webkit.org/changeset/210911>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.