Bug 167070

Summary:

Move around some Cocoa/CF specific files in WTF (especially -Mac suffixed ones)

Product:

WebKit

Reporter:

Tim Horton <thorton>

Component:

New Bugs

Assignee:

Tim Horton <thorton>

Status:

NEW

Severity:

Normal

CC:

andersca, commit-queue, mitz

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
patch ignoring renames	none
svn mv script	none
Patch	none
patch ignoring renames	none
svn mv script	none
Patch	sam: review+
patch ignoring moves	none
svn mv script	none

Tim Horton

Reported 2017-01-15 11:53:06 PST

Move around some Cocoa/CF specific files in WTF (especially -Mac suffixed ones)

Attachments
Patch (107.48 KB, patch) 2017-01-15 11:53 PST, Tim Horton	no flags	Details Formatted Diff Diff
patch ignoring renames (30.17 KB, patch) 2017-01-15 11:53 PST, Tim Horton	no flags	Details Formatted Diff Diff
svn mv script (1.22 KB, text/plain) 2017-01-15 11:54 PST, Tim Horton	no flags	Details
Patch (102.59 KB, patch) 2017-01-15 12:19 PST, Tim Horton	no flags	Details Formatted Diff Diff
patch ignoring renames (30.09 KB, patch) 2017-01-15 12:20 PST, Tim Horton	no flags	Details Formatted Diff Diff
svn mv script (1.15 KB, text/plain) 2017-01-15 12:20 PST, Tim Horton	no flags	Details
Patch (93.60 KB, patch) 2017-01-15 12:38 PST, Tim Horton	sam: review+	Details Formatted Diff Diff
patch ignoring moves (29.24 KB, patch) 2017-01-15 12:38 PST, Tim Horton	no flags	Details Formatted Diff Diff
svn mv script (997 bytes, text/plain) 2017-01-15 12:39 PST, Tim Horton	no flags	Details
Show Obsolete (6) View All Add attachment proposed patch, testcase, etc.

Tim Horton

Comment 1 2017-01-15 11:53:21 PST

Created attachment 298911 [details] Patch

Tim Horton

Comment 2 2017-01-15 11:53:50 PST

Created attachment 298912 [details] patch ignoring renames

Tim Horton

Comment 3 2017-01-15 11:54:09 PST

Created attachment 298913 [details] svn mv script

WebKit Commit Bot

Comment 4 2017-01-15 11:56:19 PST

Attachment 298911 [details] did not pass style-queue: ERROR: Source/WTF/wtf/text/cocoa/StringCocoa.mm:34: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WTF/wtf/cf/RunLoopTimerCF.cpp:33: You should not add a blank line before implementation file's own header. [build/include_order] [4] ERROR: Source/WTF/wtf/cocoa/MainThreadCocoa.mm:28: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/cocoa/AutodrainedPool.h:29: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WTF/wtf/cocoa/PlatformUserPreferredLanguagesCocoa.mm:110: No space between ^ and block definition. [whitespace/brackets] [4] Total errors found: 5 in 16 files If any of these errors are false positives, please file a bug against check-webkit-style.

Tim Horton

Comment 5 2017-01-15 12:19:46 PST

Created attachment 298920 [details] Patch

Tim Horton

Comment 6 2017-01-15 12:20:35 PST

Created attachment 298921 [details] patch ignoring renames

Tim Horton

Comment 7 2017-01-15 12:20:59 PST

Created attachment 298922 [details] svn mv script

WebKit Commit Bot

Comment 8 2017-01-15 12:22:13 PST

Attachment 298920 [details] did not pass style-queue: ERROR: Source/WTF/wtf/text/cocoa/StringCocoa.mm:34: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WTF/wtf/cf/RunLoopTimerCF.cpp:33: You should not add a blank line before implementation file's own header. [build/include_order] [4] ERROR: Source/WTF/wtf/cocoa/MainThreadCocoa.mm:28: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/cocoa/PlatformUserPreferredLanguagesCocoa.mm:110: No space between ^ and block definition. [whitespace/brackets] [4] Total errors found: 4 in 15 files If any of these errors are false positives, please file a bug against check-webkit-style.

Tim Horton

Comment 9 2017-01-15 12:38:29 PST

Created attachment 298927 [details] Patch

Tim Horton

Comment 10 2017-01-15 12:38:50 PST

Created attachment 298928 [details] patch ignoring moves

Tim Horton

Comment 11 2017-01-15 12:39:13 PST

Created attachment 298929 [details] svn mv script

WebKit Commit Bot

Comment 12 2017-01-15 12:41:21 PST

Attachment 298927 [details] did not pass style-queue: ERROR: Source/WTF/wtf/text/cocoa/StringCocoa.mm:34: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WTF/wtf/cf/RunLoopTimerCF.cpp:33: You should not add a blank line before implementation file's own header. [build/include_order] [4] ERROR: Source/WTF/wtf/cocoa/MainThreadCocoa.mm:28: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/cocoa/PlatformUserPreferredLanguagesCocoa.mm:110: No space between ^ and block definition. [whitespace/brackets] [4] Total errors found: 4 in 13 files If any of these errors are false positives, please file a bug against check-webkit-style.

Sam Weinig

Comment 13 2017-01-15 21:22:04 PST

Comment on attachment 298927 [details] Patch rs=me

Note You need to log in before you can comment on or make changes to this bug.