Bug 167028

Summary: Web Inspector: Cmd-, should open Settings tab
Product: WebKit Reporter: Blaze Burg <bburg>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, inspector-bugzilla-changes, joepeck, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Blaze Burg
Reported 2017-01-13 15:59:02 PST
This matches the system-wide shortcut in all macOS apps.
Attachments
Patch (1.79 KB, patch)
2017-01-13 20:29 PST, Devin Rousso 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2017-01-13 15:59:23 PST
<rdar://problem/30022283>
Devin Rousso
Comment 2 2017-01-13 20:29:49 PST
Created attachment 298843 [details] Patch So this works with "Fn⌘," but not with regular "⌘,". Any ideas?
WebKit Commit Bot
Comment 3 2017-01-14 22:28:48 PST
Comment on attachment 298843 [details] Patch Clearing flags on attachment: 298843 Committed r210772: <http://trac.webkit.org/changeset/210772>
WebKit Commit Bot
Comment 4 2017-01-14 22:28:52 PST
All reviewed patches have been landed. Closing bug.
Joseph Pecoraro
Comment 5 2017-01-15 21:10:48 PST
Is this a good idea? Does any application allow sub-windows to override the "⌘,"? Does any application have multiple preferences windows? I have found it very disturbing to my workflow when Web Inspector overrides some of Safari's keyboard shortcuts (notably ⌘W, ⇧⌘W). Perhaps "⌘," is so rare that it won't be a problem here.
Note You need to log in before you can comment on or make changes to this bug.