|Summary:||Web Inspector: Cmd-, should open Settings tab|
|Product:||WebKit||Reporter:||BJ Burg <bburg>|
|Component:||Web Inspector||Assignee:||Devin Rousso <drousso>|
|Severity:||Normal||CC:||commit-queue, inspector-bugzilla-changes, joepeck, webkit-bug-importer|
|Version:||WebKit Nightly Build|
Description BJ Burg 2017-01-13 15:59:02 PST
This matches the system-wide shortcut in all macOS apps.
Comment 2 Devin Rousso 2017-01-13 20:29:49 PST
Created attachment 298843 [details] Patch So this works with "Fn⌘," but not with regular "⌘,". Any ideas?
Comment 3 WebKit Commit Bot 2017-01-14 22:28:48 PST
Comment on attachment 298843 [details] Patch Clearing flags on attachment: 298843 Committed r210772: <http://trac.webkit.org/changeset/210772>
Comment 4 WebKit Commit Bot 2017-01-14 22:28:52 PST
All reviewed patches have been landed. Closing bug.
Comment 5 Joseph Pecoraro 2017-01-15 21:10:48 PST
Is this a good idea? Does any application allow sub-windows to override the "⌘,"? Does any application have multiple preferences windows? I have found it very disturbing to my workflow when Web Inspector overrides some of Safari's keyboard shortcuts (notably ⌘W, ⇧⌘W). Perhaps "⌘," is so rare that it won't be a problem here.