Summary: | Reserve capacity for StringBuilder in unescape | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Yusuke Suzuki <ysuzuki> | ||||||
Component: | New Bugs | Assignee: | Yusuke Suzuki <ysuzuki> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, keith_miller, mark.lam, msaboff, ryanhaddad, saam | ||||||
Priority: | P2 | ||||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Yusuke Suzuki
2017-01-13 09:59:37 PST
Created attachment 298766 [details]
Patch
Created attachment 298767 [details]
Patch
Comment on attachment 298767 [details]
Patch
Sweet.
Comment on attachment 298767 [details]
Patch
Thanks :)
Very nice indeed. Comment on attachment 298767 [details] Patch Clearing flags on attachment: 298767 Committed r210735: <http://trac.webkit.org/changeset/210735> All reviewed patches have been landed. Closing bug. It appears that this change caused flakiness in LayoutTest js/dom/encode-URI-test.html and JSC test mozilla-tests.yaml/ecma/GlobalObject/15.1.2.5-2.js See: https://bugs.webkit.org/show_bug.cgi?id=167020 https://build.webkit.org/builders/Apple%20El%20Capitan%20Release%20JSC%20%28Tests%29/builds/11637 Reverted r210735 for reason: This change introduced LayoutTest and JSC test flakiness. Committed r210752: <http://trac.webkit.org/changeset/210752> *** Bug 167020 has been marked as a duplicate of this bug. *** Ah, i see. I changed k and length to unsigned. Previously, it was `int`. I thought it is not intentional. But it is intentional because we would like to check the condition like `k <= length - 6` even if `length` is less than 6. I'll change this part, add comment about it, and land this patch. Committed r210766: <http://trac.webkit.org/changeset/210766> |