Bug 167008

Summary: Reserve capacity for StringBuilder in unescape
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, keith_miller, mark.lam, msaboff, ryanhaddad, saam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Yusuke Suzuki
Reported 2017-01-13 09:59:37 PST
Reserve capacity for StringBuilder in unescape
Attachments
Patch (4.73 KB, patch)
2017-01-13 10:01 PST, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (4.88 KB, patch)
2017-01-13 10:02 PST, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2017-01-13 10:01:27 PST
Created attachment 298766 [details] Patch
Yusuke Suzuki
Comment 2 2017-01-13 10:02:50 PST
Created attachment 298767 [details] Patch
Sam Weinig
Comment 3 2017-01-13 10:05:53 PST
Comment on attachment 298767 [details] Patch Sweet.
Yusuke Suzuki
Comment 4 2017-01-13 10:06:48 PST
Comment on attachment 298767 [details] Patch Thanks :)
Mark Lam
Comment 5 2017-01-13 10:07:25 PST
Very nice indeed.
WebKit Commit Bot
Comment 6 2017-01-13 10:31:15 PST
Comment on attachment 298767 [details] Patch Clearing flags on attachment: 298767 Committed r210735: <http://trac.webkit.org/changeset/210735>
WebKit Commit Bot
Comment 7 2017-01-13 10:31:18 PST
All reviewed patches have been landed. Closing bug.
Ryan Haddad
Comment 8 2017-01-13 16:59:37 PST
It appears that this change caused flakiness in LayoutTest js/dom/encode-URI-test.html and JSC test mozilla-tests.yaml/ecma/GlobalObject/15.1.2.5-2.js See: https://bugs.webkit.org/show_bug.cgi?id=167020 https://build.webkit.org/builders/Apple%20El%20Capitan%20Release%20JSC%20%28Tests%29/builds/11637
Ryan Haddad
Comment 9 2017-01-13 17:04:24 PST
Reverted r210735 for reason: This change introduced LayoutTest and JSC test flakiness. Committed r210752: <http://trac.webkit.org/changeset/210752>
Ryan Haddad
Comment 10 2017-01-13 17:04:39 PST
*** Bug 167020 has been marked as a duplicate of this bug. ***
Yusuke Suzuki
Comment 11 2017-01-14 02:15:46 PST
Ah, i see. I changed k and length to unsigned. Previously, it was `int`. I thought it is not intentional. But it is intentional because we would like to check the condition like `k <= length - 6` even if `length` is less than 6. I'll change this part, add comment about it, and land this patch.
Yusuke Suzuki
Comment 12 2017-01-14 08:21:06 PST
Committed r210766: <http://trac.webkit.org/changeset/210766>
Note You need to log in before you can comment on or make changes to this bug.