Bug 167000 – Support min() and max() in calc()

• Component: CSS
• Status: RESOLVED FIXED

[Myles C. Maxfield]

The CSSWG just resolved to add these.

[Myles C. Maxfield]

Created attachment 298742 [details]
WIP

[Radar WebKit Bug Importer]

<rdar://problem/30153481>

[Tim Horton]

Created attachment 318155 [details]
parsing half works now

[Build Bot]

Attachment 318155 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:9:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Build Bot]

Comment on attachment 318155 [details]
parsing half works now

Attachment 318155 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/4319705

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 318180 [details]
Archive of layout-test-results from ews112 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Tim Horton]

Created attachment 318198 [details]
fix tests; parse n>2 min()/max() items

[Dean Jackson]

Is this for review? Or did it land?

[Dean Jackson]

I don't see a commit, so I guess not.

[Tim Horton]

Not yet. Needs tests! And probably some cleanup. It's more of a [WIP] than anything, I was just pushing it along.

[Dean Jackson]

Comment on attachment 318198 [details]
fix tests; parse n>2 min()/max() items

View in context: https://bugs.webkit.org/attachment.cgi?id=318198&action=review

> Source/WebCore/ChangeLog:9
> +        No new tests... yet.

I guess this is why there isn't a review :)

> Source/WebCore/css/CSSCalculationValue.cpp:552
> +            if (m_children.isEmpty())
> +                return CSSPrimitiveValue::CSS_UNKNOWN;

Can this ever happen?

> Source/WebCore/platform/CalculationValue.cpp:102
> +        if (m_children.isEmpty())
> +            return std::numeric_limits<float>::quiet_NaN();

Can this happen?

You have ASSERT(!childExpressions.isEmpty()); above, as well as this in the parser:

if (!parseValueTerm(innerRange, depth, &value))
      return false;


Maybe we should fail elsewhere too?

[Darin Adler]

Comment on attachment 318198 [details]
fix tests; parse n>2 min()/max() items

View in context: https://bugs.webkit.org/attachment.cgi?id=318198&action=review

> Source/WebCore/platform/CalculationValue.h:228
> -inline bool operator==(const CalcExpressionBinaryOperation& a, const CalcExpressionBinaryOperation& b)
> +inline bool operator==(const CalcExpressionOperation& a, const CalcExpressionOperation& b)
>  {
>      return a.getOperator() == b.getOperator() && a.leftSide() == b.leftSide() && a.rightSide() == b.rightSide();
>  }

The implementation of this function doesn’t seem right any more.

[Tim Horton]

(In reply to Darin Adler from comment #12)
> Comment on attachment 318198 [details]
> fix tests; parse n>2 min()/max() items
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=318198&action=review
> 
> > Source/WebCore/platform/CalculationValue.h:228
> > -inline bool operator==(const CalcExpressionBinaryOperation& a, const CalcExpressionBinaryOperation& b)
> > +inline bool operator==(const CalcExpressionOperation& a, const CalcExpressionOperation& b)
> >  {
> >      return a.getOperator() == b.getOperator() && a.leftSide() == b.leftSide() && a.rightSide() == b.rightSide();
> >  }
> 
> The implementation of this function doesn’t seem right any more.

Not even slightly.

[Alan Stearns]

Please consider adding tests to WPT for this, (instead of|in addition to) WebKit-specific tests.

[Tim Horton]

(In reply to Alan Stearns from comment #14)
> Please consider adding tests to WPT for this, (instead of|in addition to)
> WebKit-specific tests.

I intend to, though the patch I'm about to upload just revives the existing-ish WebKit tests.

[Tim Horton]

Created attachment 320673 [details]
Patch

[Build Bot]

Comment on attachment 320673 [details]
Patch

Attachment 320673 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/4537076

New failing tests:
fast/block/positive-margin-block-child-align-center-calc.html
css3/supports-dom-api.html
css3/supports.html
css3/calc/simple-calcs-prefixed.html

[Build Bot]

Created attachment 320683 [details]
Archive of layout-test-results from ews100 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 320673 [details]
Patch

Attachment 320673 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/4537136

New failing tests:
fast/block/positive-margin-block-child-align-center-calc.html
css3/supports-dom-api.html
css3/supports.html
css3/calc/simple-calcs-prefixed.html

[Build Bot]

Created attachment 320685 [details]
Archive of layout-test-results from ews105 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 320673 [details]
Patch

Attachment 320673 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/4537134

New failing tests:
fast/block/positive-margin-block-child-align-center-calc.html
css3/supports-dom-api.html
css3/supports.html
css3/calc/simple-calcs-prefixed.html

[Build Bot]

Created attachment 320687 [details]
Archive of layout-test-results from ews116 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 320673 [details]
Patch

Attachment 320673 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/4537195

New failing tests:
fast/block/positive-margin-block-child-align-center-calc.html
css3/supports-dom-api.html
css3/supports.html
css3/calc/simple-calcs-prefixed.html

[Build Bot]

Created attachment 320690 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.5

[Tim Horton]

Created attachment 320877 [details]
Patch

[Dave Hyatt]

Comment on attachment 320877 [details]
Patch

r=me

[WebKit Commit Bot]

Comment on attachment 320877 [details]
Patch

Clearing flags on attachment: 320877

Committed r222190: <http://trac.webkit.org/changeset/222190>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Joonghun Park]

*** Bug 143515 has been marked as a duplicate of this bug. ***