Bug 16700

Summary:

Fix -[WebDefaultPolicyDelegate webView:decidePolicyForMIMEType:request:frame:decisionListener:]

Product:

WebKit

Reporter:

David Kilzer (:ddkilzer) <ddkilzer>

Component:

WebKit Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

opendarwin

Priority:

Version:

528+ (Nightly build)

Hardware:

Mac

OS:

OS X 10.4

Bug Depends on:

12111

Bug Blocks:

Attachments:

Description	Flags
Patch v1	mitz: review+

Description David Kilzer (:ddkilzer) 2008-01-01 15:36:00 PST

The fix for Bug 12111 was not fully correct.  The return value of -[NSFileManager fileExistsAtPath:isDirectory:] should be checked.

See Bug 12111 Comment #8.

Comment 1 David Kilzer (:ddkilzer) 2008-01-01 15:55:06 PST

Created attachment 18228 [details]
Patch v1

Use the return value of -[NSFileManager fileExistsAtPath:isDirectory:] and clean up code for WebKit style (remove extraneous curly braces in if/else statements).

Comment 2 mitz 2008-01-01 16:09:44 PST

Comment on attachment 18228 [details]
Patch v1

r=me

Comment 3 David Kilzer (:ddkilzer) 2008-01-01 16:38:32 PST

Committed revision 29072.