Bug 16700

Summary:

Fix -[WebDefaultPolicyDelegate webView:decidePolicyForMIMEType:request:frame:decisionListener:]

Product:

WebKit

Reporter:

David Kilzer (:ddkilzer) <ddkilzer>

Component:

WebKit Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

opendarwin

Priority:

Version:

528+ (Nightly build)

Hardware:

Mac

OS:

OS X 10.4

Bug Depends on:

12111

Bug Blocks:

Attachments:

Description	Flags
Patch v1	mitz: review+

David Kilzer (:ddkilzer)

Reported 2008-01-01 15:36:00 PST

The fix for Bug 12111 was not fully correct. The return value of -[NSFileManager fileExistsAtPath:isDirectory:] should be checked. See Bug 12111 Comment #8.

Attachments
Patch v1 (1.90 KB, patch) 2008-01-01 15:55 PST, David Kilzer (:ddkilzer)	mitz: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

David Kilzer (:ddkilzer)

Comment 1 2008-01-01 15:55:06 PST

Created attachment 18228 [details] Patch v1 Use the return value of -[NSFileManager fileExistsAtPath:isDirectory:] and clean up code for WebKit style (remove extraneous curly braces in if/else statements).

mitz

Comment 2 2008-01-01 16:09:44 PST

Comment on attachment 18228 [details] Patch v1 r=me

David Kilzer (:ddkilzer)

Comment 3 2008-01-01 16:38:32 PST

Committed revision 29072.

Note You need to log in before you can comment on or make changes to this bug.