Bug 166991

Summary:

Web Inspector: add UI Zoom level to Settings screen

Product:

WebKit

Reporter:

Blaze Burg <bburg>

Component:

Web Inspector

Assignee:

Devin Rousso <hi>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bburg, commit-queue, hi, inspector-bugzilla-changes, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none
[Image] After Patch is applied	none
[Image] Page Zoom setting	none
Patch	none

Blaze Burg

Reported 2017-01-12 15:10:32 PST

This will make it more discoverable!

Attachments
Patch (7.69 KB, patch) 2017-01-13 21:02 PST, Devin Rousso	no flags	Details Formatted Diff Diff
[Image] After Patch is applied (191.65 KB, image/png) 2017-01-13 21:03 PST, Devin Rousso	no flags	Details
[Image] Page Zoom setting (272.84 KB, image/png) 2017-01-13 22:40 PST, Matt Baker	no flags	Details
Patch (7.78 KB, patch) 2017-01-14 16:00 PST, Devin Rousso	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2017-01-12 15:13:52 PST

<rdar://problem/30002034>

Devin Rousso

Comment 2 2017-01-13 21:02:55 PST

Created attachment 298846 [details] Patch

Devin Rousso

Comment 3 2017-01-13 21:03:19 PST

Created attachment 298847 [details] [Image] After Patch is applied

Matt Baker

Comment 4 2017-01-13 22:40:40 PST

Created attachment 298849 [details] [Image] Page Zoom setting It might be better to expose this as a dropdown with percentages, like Safari.

Devin Rousso

Comment 5 2017-01-14 16:00:34 PST

Created attachment 298865 [details] Patch

Blaze Burg

Comment 6 2017-01-16 10:03:32 PST

Comment on attachment 298865 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=298865&action=review r=me > Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js:153 > + this.element.appendChild(document.createElement("br")); Fairly soon we should start thinking about having different sections, like Xcode's word / scope buttons or Mail's icons. Not yet though :) > Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js:162 > + [0.6, 0.8, 1, 1.2, 1.4, 1.6, 1.8, 2, 2.2, 2.4].forEach((level) => { Very nice.

WebKit Commit Bot

Comment 7 2017-01-16 13:13:01 PST

Comment on attachment 298865 [details] Patch Clearing flags on attachment: 298865 Committed r210788: <http://trac.webkit.org/changeset/210788>

WebKit Commit Bot

Comment 8 2017-01-16 13:13:05 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.