Bug 166920

Summary: Remove request.formData property until it gets implemented
Product: WebKit Reporter: Anne van Kesteren <annevk>
Component: DOMAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, esprehn+autocc, kondapallykalyan, sam, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: Safari Technology Preview   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 161190    
Attachments:
Description Flags
Patch
none
Patch for landing none

Description Anne van Kesteren 2017-01-11 00:56:40 PST
From testing at https://github.com/w3c/web-platform-tests/pull/4517 it appears that formData() is not implemented. If that's the case it would be better to leave it undefined.
Comment 1 Chris Dumez 2017-01-11 08:50:34 PST
+Youenn. As far as I can see, our FetchRequest interface already implements FetchBody, which has the formData() operation.
Comment 2 Chris Dumez 2017-01-11 08:53:40 PST
Could be due to:
if (isFormData()) {
        // FIXME: Support consuming FormData.

in FetchBody::consume().
Comment 3 Anne van Kesteren 2017-01-11 10:02:55 PST
If you can't implement it before shipping, it would be better to drop the method from the IDL entirely. That's what Chrome is doing (Firefox supports it). Otherwise web developers will have to sniff this in two different ways.
Comment 4 Radar WebKit Bug Importer 2017-01-11 10:07:27 PST
<rdar://problem/29971105>
Comment 5 Sam Weinig 2017-01-11 12:28:02 PST
I'll take a look at fixing this unless Youenn is already started on it.
Comment 6 youenn fablet 2017-01-11 12:36:38 PST
(In reply to comment #5)
> I'll take a look at fixing this unless Youenn is already started on it.

I was about to fix it, but please go ahead!
Comment 7 youenn fablet 2017-01-11 15:10:51 PST
I forgot there was already bug 161190 to cover this one.
I'll use this bug entry to land the one-liner patch to remove the property.
This is safer doing it that way for all WebKit users.
Comment 8 youenn fablet 2017-01-11 15:15:44 PST
Created attachment 298617 [details]
Patch
Comment 9 Chris Dumez 2017-01-11 15:19:26 PST
Comment on attachment 298617 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=298617&action=review

r=me

> Source/WebCore/Modules/fetch/FetchBody.idl:40
> +    // FIXME: Add support for form data consumption (https://bugs.webkit.org/show_bug.cgi?id=161190)

nit: Missing period at the end.
Comment 10 youenn fablet 2017-01-11 17:58:31 PST
Created attachment 298647 [details]
Patch for landing
Comment 11 WebKit Commit Bot 2017-01-11 18:45:34 PST
Comment on attachment 298647 [details]
Patch for landing

Clearing flags on attachment: 298647

Committed r210616: <http://trac.webkit.org/changeset/210616>
Comment 12 WebKit Commit Bot 2017-01-11 18:45:41 PST
All reviewed patches have been landed.  Closing bug.