Summary: | Remove request.formData property until it gets implemented | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Anne van Kesteren <annevk> | ||||||
Component: | DOM | Assignee: | youenn fablet <youennf> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | cdumez, commit-queue, esprehn+autocc, kondapallykalyan, sam, webkit-bug-importer, youennf | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | Safari Technology Preview | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 161190 | ||||||||
Attachments: |
|
Description
Anne van Kesteren
2017-01-11 00:56:40 PST
+Youenn. As far as I can see, our FetchRequest interface already implements FetchBody, which has the formData() operation. Could be due to: if (isFormData()) { // FIXME: Support consuming FormData. in FetchBody::consume(). If you can't implement it before shipping, it would be better to drop the method from the IDL entirely. That's what Chrome is doing (Firefox supports it). Otherwise web developers will have to sniff this in two different ways. I'll take a look at fixing this unless Youenn is already started on it. (In reply to comment #5) > I'll take a look at fixing this unless Youenn is already started on it. I was about to fix it, but please go ahead! I forgot there was already bug 161190 to cover this one. I'll use this bug entry to land the one-liner patch to remove the property. This is safer doing it that way for all WebKit users. Created attachment 298617 [details]
Patch
Comment on attachment 298617 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=298617&action=review r=me > Source/WebCore/Modules/fetch/FetchBody.idl:40 > + // FIXME: Add support for form data consumption (https://bugs.webkit.org/show_bug.cgi?id=161190) nit: Missing period at the end. Created attachment 298647 [details]
Patch for landing
Comment on attachment 298647 [details] Patch for landing Clearing flags on attachment: 298647 Committed r210616: <http://trac.webkit.org/changeset/210616> All reviewed patches have been landed. Closing bug. |