Bug 166920 – Remove request.formData property until it gets implemented

• Component: DOM
• Status: RESOLVED FIXED

[Anne van Kesteren]

From testing at https://github.com/w3c/web-platform-tests/pull/4517 it appears that formData() is not implemented. If that's the case it would be better to leave it undefined.

[Chris Dumez]

+Youenn. As far as I can see, our FetchRequest interface already implements FetchBody, which has the formData() operation.

[Chris Dumez]

Could be due to:
if (isFormData()) {
        // FIXME: Support consuming FormData.

in FetchBody::consume().

[Anne van Kesteren]

If you can't implement it before shipping, it would be better to drop the method from the IDL entirely. That's what Chrome is doing (Firefox supports it). Otherwise web developers will have to sniff this in two different ways.

[Radar WebKit Bug Importer]

<rdar://problem/29971105>

[Sam Weinig]

I'll take a look at fixing this unless Youenn is already started on it.

[youenn fablet]

(In reply to comment #5)
> I'll take a look at fixing this unless Youenn is already started on it.

I was about to fix it, but please go ahead!

[youenn fablet]

I forgot there was already bug 161190 to cover this one.
I'll use this bug entry to land the one-liner patch to remove the property.
This is safer doing it that way for all WebKit users.

[youenn fablet]

Created attachment 298617 [details]
Patch

[Chris Dumez]

Comment on attachment 298617 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=298617&action=review

r=me

> Source/WebCore/Modules/fetch/FetchBody.idl:40
> +    // FIXME: Add support for form data consumption (https://bugs.webkit.org/show_bug.cgi?id=161190)

nit: Missing period at the end.

[youenn fablet]

Created attachment 298647 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 298647 [details]
Patch for landing

Clearing flags on attachment: 298647

Committed r210616: <http://trac.webkit.org/changeset/210616>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.