Bug 166918

Summary: [iOS][WK2] KeyboardEvent.key always returns an empty string
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: DOMAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, darin, simon.fraser, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Chris Dumez
Reported 2017-01-10 19:50:59 PST
Make sure KeyboardEvent.key is properly initialized on iOS WK2.
Attachments
Patch (7.68 KB, patch)
2017-01-10 20:38 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (8.00 KB, patch)
2017-01-10 20:54 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2017-01-10 19:51:14 PST
<rdar://problem/29861147>
Chris Dumez
Comment 2 2017-01-10 20:38:52 PST
Created attachment 298550 [details] Patch
Chris Dumez
Comment 3 2017-01-10 20:43:09 PST
Comment on attachment 298550 [details] Patch Will fix EFL.
Wenson Hsieh
Comment 4 2017-01-10 20:46:58 PST
Comment on attachment 298550 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=298550&action=review > LayoutTests/fast/events/ios/keyboard-event-key-attribute.html:23 > +function getInputFocusUIScript() Nit - I would pass x, y as arguments to the function here. > LayoutTests/fast/events/ios/keyboard-event-key-attribute.html:49 > + window.setTimeout(function() { Instead of using a timeout here, I think you use didShowKeyboardCallback. See fast/events/ios/keyboard-should-not-trigger-resize.html for an example.
Chris Dumez
Comment 5 2017-01-10 20:54:06 PST
Created attachment 298552 [details] Patch
WebKit Commit Bot
Comment 6 2017-01-11 07:46:38 PST
Comment on attachment 298552 [details] Patch Clearing flags on attachment: 298552 Committed r210586: <http://trac.webkit.org/changeset/210586>
WebKit Commit Bot
Comment 7 2017-01-11 07:46:44 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.