Bug 166861 – Implement JSSourceCode to propagate SourceCode in module pipeline

• Component: JavaScriptCore
• Status: RESOLVED FIXED

[Yusuke Suzuki]

...

[Yusuke Suzuki]

Created attachment 298392 [details]
Patch

[Yusuke Suzuki]

Created attachment 298393 [details]
Patch

[Saam Barati]

Comment on attachment 298393 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=298393&action=review

> Source/WebCore/ForwardingHeaders/runtime/JSSourceCode.h:2
> + * Copyright (C) Yusuke Suzuki <[e-mail]>

I think you should probably add the year here.

> Source/WebCore/ForwardingHeaders/runtime/JSSourceCode.h:27
> +#ifndef WebCore_FWD_JSSourceCode_h
> +#define WebCore_FWD_JSSourceCode_h

#pragma once?

[Yusuke Suzuki]

Comment on attachment 298393 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=298393&action=review

I'll land it once I fixed the build failures.

>> Source/WebCore/ForwardingHeaders/runtime/JSSourceCode.h:2
>> + * Copyright (C) Yusuke Suzuki <[e-mail]>
> 
> I think you should probably add the year here.

Oops. Thanks.

>> Source/WebCore/ForwardingHeaders/runtime/JSSourceCode.h:27
>> +#define WebCore_FWD_JSSourceCode_h
> 
> #pragma once?

Changed.

[Yusuke Suzuki]

Comment on attachment 298393 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=298393&action=review

> Source/WebCore/bindings/js/JSDOMPromise.h:98
> +    void resolve(Callback callback, Value value)

Oops. This `resolve` name is ambiguous with the `void resolve(JSC::ExecState& state, JSC::JSValue resolution) { callFunction(state, m_deferred->resolve(), resolution); }` case.
I've renamed it to `resolveWithCallback`.

[Yusuke Suzuki]

Created attachment 298401 [details]
Patch for landing

Patch for landing

[Yusuke Suzuki]

Created attachment 298411 [details]
Patch for landing

Patch for landing

[Build Bot]

Comment on attachment 298401 [details]
Patch for landing

Attachment 298401 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2860738

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 298417 [details]
Archive of layout-test-results from ews102 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 298401 [details]
Patch for landing

Attachment 298401 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2860752

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 298419 [details]
Archive of layout-test-results from ews112 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Yusuke Suzuki]

Created attachment 298422 [details]
Patch for landing

Patch for landing

[Build Bot]

Comment on attachment 298411 [details]
Patch for landing

Attachment 298411 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2860925

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 298424 [details]
Archive of layout-test-results from ews100 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 298411 [details]
Patch for landing

Attachment 298411 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2860902

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 298425 [details]
Archive of layout-test-results from ews113 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 298401 [details]
Patch for landing

Attachment 298401 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2860840

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 298426 [details]
Archive of layout-test-results from ews126 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 298411 [details]
Patch for landing

Attachment 298411 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2861034

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 298428 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6

[Yusuke Suzuki]

Created attachment 298430 [details]
Patch for landing

Patch for landing

[Build Bot]

Comment on attachment 298422 [details]
Patch for landing

Attachment 298422 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2861303

New failing tests:
http/tests/security/contentSecurityPolicy/module-eval-blocked.html

[Build Bot]

Created attachment 298431 [details]
Archive of layout-test-results from ews100 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 298422 [details]
Patch for landing

Attachment 298422 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2861286

New failing tests:
http/tests/security/contentSecurityPolicy/module-eval-blocked.html

[Build Bot]

Created attachment 298432 [details]
Archive of layout-test-results from ews115 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 298422 [details]
Patch for landing

Attachment 298422 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2861343

New failing tests:
http/tests/security/contentSecurityPolicy/module-eval-blocked.html

[Build Bot]

Created attachment 298433 [details]
Archive of layout-test-results from ews126 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 298422 [details]
Patch for landing

Attachment 298422 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2861435

New failing tests:
http/tests/security/contentSecurityPolicy/module-eval-blocked.html

[Build Bot]

Created attachment 298434 [details]
Archive of layout-test-results from ews105 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 298411 [details]
Patch for landing

Attachment 298411 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2861560

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 298440 [details]
Archive of layout-test-results from ews123 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6

[Yusuke Suzuki]

Comment on attachment 298430 [details]
Patch for landing

OK, rebaseline the test result, and add the missing JSSourceCode use for ModuleLoader's provide method.

[Build Bot]

Comment on attachment 298411 [details]
Patch for landing

Attachment 298411 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2861867

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 298445 [details]
Archive of layout-test-results from ews105 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[Yusuke Suzuki]

Committed r210537: <http://trac.webkit.org/changeset/210537>

[WebKit Commit Bot]

Re-opened since this is blocked by bug 166903

[Ryan Haddad]

(In reply to comment #36)
> Re-opened since this is blocked by bug 166903

Rolled out in http://trac.webkit.org/changeset/210557 due to 700+ JSC test failures:

https://build.webkit.org/builders/Apple%20Sierra%20Debug%20JSC%20%28Tests%29/builds/119

[Yusuke Suzuki]

(In reply to comment #37)
> (In reply to comment #36)
> > Re-opened since this is blocked by bug 166903
> 
> Rolled out in http://trac.webkit.org/changeset/210557 due to 700+ JSC test
> failures:
> 
> https://build.webkit.org/builders/Apple%20Sierra%20Debug%20JSC%20%28Tests%29/
> builds/119

Ah, OK. It's just because JSC shell's makeSource misses Module SourceType for fetching.

[Yusuke Suzuki]

Committed r210573: <http://trac.webkit.org/changeset/210573>

[Yusuke Suzuki]

Reland it with JSC shell makeSource with SourceType::Module. Thanks :)